Problem/Motivation

Filtering by text in management form for paragraphs fail. Paragraphs don't have a label key, so we cannot filter by it.

Proposed resolution

Remove the filter if there is no label key in an entity. Don't use an existing filter if there is no label key.

Remaining tasks

None.

User interface changes

No text filter for entities without a label. It is useless.

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

The last submitted patch, 2: 2879089-paragraphs-filter-2.only-tests.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2879089-paragraphs-filter-2.patch, failed testing.

penyaskito’s picture

The last submitted patch, 5: 2879089-paragraphs-filter-4.only-tests.patch, failed testing.

penyaskito’s picture

Status: Needs review » Reviewed & tested by the community

Tests failed and passed as expected.

  • penyaskito committed 0e637fc on 8.x-1.x
    Issue #2879089 by penyaskito: Filtering by text in management form for...
penyaskito’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Reviewed & tested by the community » Needs work

Committed 0e637fc and pushed to 8.x-1.x. Thanks!
Needs reroll for 8.x-2.x

penyaskito’s picture

penyaskito’s picture

Status: Needs work » Needs review

The last submitted patch, 10: 2879089-paragraphs-filter-10.only-tests.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 10: 2879089-paragraphs-filter-10.patch, failed testing.

penyaskito’s picture

The last submitted patch, 14: 2879089-paragraphs-filter-14.only-tests.patch, failed testing.

penyaskito’s picture

Status: Needs review » Reviewed & tested by the community

Tests failed and passed as expected.

  • penyaskito committed 795723d on 8.x-2.x
    Issue #2879089 by penyaskito: Filtering by text in management form for...
penyaskito’s picture

Status: Reviewed & tested by the community » Fixed

Committed 795723d and pushed to 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.