There's a typo in the variable name in the country cache context

 /**
   * The current country.
   *
   * @var \Drupal\commerce\CurrentCountry
   */
  protected $currentCcountry;
CommentFileSizeAuthor
#2 typo_in_variable_name-2879054-2.patch481 bytessumanthkumarc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sumanthkumarc created an issue. See original summary.

sumanthkumarc’s picture

sumanthkumarc CreditAttribution: sumanthkumarc at Azri Solutions commented
FileSize
typo_in_variable_name-2879054-2.patch481 bytes

Attaching patch

sumanthkumarc’s picture

sumanthkumarc CreditAttribution: sumanthkumarc at Azri Solutions commented
Status: Active » Needs review

changing to needs review, also this is major because this breaks the functionality itself.

sumanthkumarc’s picture

sumanthkumarc CreditAttribution: sumanthkumarc at Azri Solutions commented

Also raised PR here: https://github.com/drupalcommerce/commerce/pull/738

  • bojanz committed 5a1b68c on 8.x-2.x authored by sumanthkumarc 
    Issue #2879054 by sumanthkumarc: Typo in variable name in Country cache...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Priority: Major » Minor
Status: Needs review » Fixed

Thanks!

sumanthkumarc’s picture

sumanthkumarc CreditAttribution: sumanthkumarc at Azri Solutions commented

Also i can confirm that this context works and i am able to see variations of the cached copies varying by the country and has country code in cid.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.