We should convert the module to short array as per new coding standard

CommentFileSizeAuthor
#3 registration_validation_array_search_results.png51.05 KBdhruveshdtripathi
#2 2878993-2.patch7.25 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
2878993-2.patch7.25 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
registration_validation_array_search_results.png51.05 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 10 array declarations, after applying patch there is 1. That 1 remaining array declaration is in_array.

Good work!

Richard Buchanan’s picture

Richard Buchanan CreditAttribution: Richard Buchanan commented
Status: Reviewed & tested by the community » Fixed

Thanks for catching this! Committed to dev and will publish new release soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.