The range slider widget forces that the base slider processor is activated via isPropertyRequired() implementation, but it should be the range_slider clearly. Not only that this does not guarantuee that the really needed processor is enabled, this is actually forcing a misconfiguration resulting in SliderProcessor::postQuery() getting executed twice - one time from the range_slider processor itself and one time per directly calling the parent SliderProcessor class.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agoradesign created an issue. See original summary.

agoradesign’s picture

Status: Active » Needs review
FileSize
719 bytes

Here's the patch

borisson_’s picture

Status: Needs review » Reviewed & tested by the community
borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks!

borisson_’s picture

agoradesign’s picture

Where? Can't find it in the recent commit log!?

agoradesign’s picture

Now I see... you were hiding it in that commit: http://cgit.drupalcode.org/facets/commit/?id=34d43b4

borisson_’s picture

I'm afraid I messed up the commits, I committed a bunch of issues in one go and it got lumped in with http://cgit.drupalcode.org/facets/commit/?id=34d43b40b62a556e88e3eb2283e..., I can revert that patch and credit you again if you want.

agoradesign’s picture

No, forget it.. that's not that important.. Problem was that I was a little bit confused, as on updating the module, applying the patch failed, but I couldn't find the commit among the recent ones at first sight

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.