Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In light of the 30-day issue that has been closed, I still recently had my generated snippets removed from sites/default/files. Due to a permissions error in how these files were removed, I couldn't just save the configuration form to re-create the files; I was on v1.2. In my case, I'm using inline snippets and was confused as to why my inline snippets stopped working because files were removed: if they're not being served, why would they be generated?
Attached is a patch to change inline snippets to use Drupal's cache instead of files. This patch provides a few perks:
- Doesn't have to hit the file system in any way
- JIT support is easier to manage should a cache clear occur
- Could be used as a backup for sites that have issues creating the snippet files (not part of this patch)
- Maintains the benefit of pre-generating the snippets so long as the cache is primed; JIT helps maintain this
I'm willing to iterate on this to get it working. My organization, which hosts a number of Drupal sites, has stuck with v1.0 because of the snippet file generation problems. This patch should help assuage these concerns, as well as decouple file system usage when it's unneeded.
| Comment | File | Size | Author |
|---|---|---|---|
| snippet_cache.patch | 4.44 KB | fractile81 |
Comments
Comment #2
solotandem CreditAttribution: solotandem commentedBased on what you wrote, your confusion would seem to stem from equating inline JS to build-on-the-fly.
The recommended approach of this module (and core, in particular in the 8.x branch) is to include JS snippets as files (i.e., avoid inline JS). Therefore the snippet 'cache' is the file, loaded and inlined if desired. If inline was the preferred approach, then a database cache entry would also make sense. Your patch is reasonable for doing a cache entry, but I am not inclined to implement it for the reason just stated.
Why exactly do you want to inline this JS? Because it has always been done this way for things like analytics? Or something else?
Regarding the 'snippet file generation problems', these were resolved in commits on April 7 (first commit after 1.2 tag) and May 13 (for those needing variable realm support). The former predates this issue by a month; will assume the latter was not relevant to your use case. The generation problem in the 1.2 release in any case only affected module 'updates' not fresh installs (unless realm support was needed) and, even using the 1.2 release, was easily resolved by disable and enable of the module.
Comment #3
solotandem CreditAttribution: solotandem commentedI think this title is more descriptive of the request.
Comment #4
solotandem CreditAttribution: solotandem commentedMarking fixed in absence of followup from reporter.