Problem/Motivation

When you try to download XLIFF files by using the "here" link int the "Exported file can be downloaded here." message. The file is just opened in the browser instead of downloaded.

Proposed resolution

We should force the download by adding the download attribute to the link. This way no matter how the user has their browser setup, the file will always be downloaded.

Xliff file download link

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

haynescw created an issue. See original summary.

haynescw’s picture

haynescw’s picture

Status: Active » Needs review

Patch above needs review. Thanks.

Status: Needs review » Needs work

The last submitted patch, 2: xliff-file-download-link-2878086-1.patch, failed testing.

haynescw’s picture

Status: Needs work » Needs review

Im not sure why the test failed considering what i added has nothing to do with ajax. I applied the patch to my site and the new download link attribute that i added shows up and the file downloads like i expected it too. My next step is to test the patch on simplytest.me and make sure its working there as well.

Status: Needs review » Needs work

The last submitted patch, 2: xliff-file-download-link-2878086-1.patch, failed testing.

haynescw’s picture

Status: Needs work » Needs review

Just tested the patch on simplytest.me and everything is working fine. Still not sure why the tests are failing my guess is that there is an open ticket for the or there should be.

DuneBL’s picture

Hello haynescw, I confirm that the patch is working well!
Thank you.
SHould be committed as it's a one line patch

mpp’s picture

Re-testing patch from #1.

Berdir’s picture

Status: Needs review » Fixed

Thought about test coverage but I think it's not really worth it, merged.

  • Berdir committed 0ce8a30 on 8.x-1.x authored by haynescw
    Issue #2878086 by haynescw, mpp: Download link for XLIFF file opens file...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.