Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
When you try to download XLIFF files by using the "here" link int the "Exported file can be downloaded here." message. The file is just opened in the browser instead of downloaded.
Proposed resolution
We should force the download by adding the download attribute to the link. This way no matter how the user has their browser setup, the file will always be downloaded.
Comment | File | Size | Author |
---|---|---|---|
#9 | xliff-file-download-link-2878086-9.patch | 903 bytes | mpp |
| |||
#2 | xliff-file-download-link-2878086-1.patch | 903 bytes | haynescw |
xliff download link.png | 5.18 KB | haynescw |
Comments
Comment #2
haynescw CreditAttribution: haynescw at ICF commentedSubtle and Simple fix.
Comment #3
haynescw CreditAttribution: haynescw at ICF commentedPatch above needs review. Thanks.
Comment #5
haynescw CreditAttribution: haynescw at ICF commentedIm not sure why the test failed considering what i added has nothing to do with ajax. I applied the patch to my site and the new download link attribute that i added shows up and the file downloads like i expected it too. My next step is to test the patch on simplytest.me and make sure its working there as well.
Comment #7
haynescw CreditAttribution: haynescw at ICF commentedJust tested the patch on simplytest.me and everything is working fine. Still not sure why the tests are failing my guess is that there is an open ticket for the or there should be.
Comment #8
DuneBLHello haynescw, I confirm that the patch is working well!
Thank you.
SHould be committed as it's a one line patch
Comment #9
mpp CreditAttribution: mpp as a volunteer and at AmeXio commentedRe-testing patch from #1.
Comment #10
BerdirThought about test coverage but I think it's not really worth it, merged.