I am getting the following error in the console when adding a Fivestar field:

Uncaught TypeError: Cannot read property 'prototype' of undefined
    at fivestar.js?v=8.3.1:99
    at fivestar.js?v=8.3.1:10

When I enable JS aggregation, it actually breaks the page display. I narrowed it down to a missing dependency on core/drupal.ajax in fivestar.libraries.yml.

CommentFileSizeAuthor
#2 cannot-read-property-prototype-undefined-2877499-2.patch399 bytesyusufhm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yusufhm created an issue. See original summary.

yusufhm’s picture

yusufhm
Primary language English
Location NSW, Australia
CreditAttribution: yusufhm at Acquia commented
Status: Needs work » Needs review
FileSize
cannot-read-property-prototype-undefined-2877499-2.patch399 bytes

Adding patch.

dbt102’s picture

dbt102 CreditAttribution: dbt102 at Pineshore, BACnet Interest Group - Drupal commented
Assigned: yusufhm » dbt102

Reviewing the patch for this now ...

dbt102’s picture

dbt102 CreditAttribution: dbt102 at Pineshore, BACnet Interest Group - Drupal commented
Status: Needs review » Reviewed & tested by the community

I tried to replicate the error, by ading advagg module. Couldn't get it to break the page. Did not try to replicate the console error.

The patch applied OK though, and my test site seems to work just fine, so will commit in a bit.

  • dbt102 committed f282a43 on 8.x-1.x authored by yusufhm 
    Issue #2877499 by yusufhm, dbt102: Uncaught TypeError: Cannot read...
dbt102’s picture

dbt102 CreditAttribution: dbt102 at Pineshore, BACnet Interest Group - Drupal commented
Status: Reviewed & tested by the community » Fixed
dbt102’s picture

dbt102 CreditAttribution: dbt102 at Pineshore, BACnet Interest Group - Drupal commented

thanks for the patch @yusufhm

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.