ConfigEntityQuery::addOrderBy is a little bit strange. If you define sorting for a view, the $field var is set. If you switch the sorting over table-sorting, then only the $alias var is set. So addOrderBy should work in both cases

CommentFileSizeAuthor
#4 sorting_issue-2877275-4.patch609 byteschr.fritsch
#2 sorting_issue-2877275-2.patch609 byteschr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review
FileSize
sorting_issue-2877275-2.patch609 bytes

Here is a patch to fix it

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Needs work 
+++ b/src/Plugin/views/query/ConfigEntityQuery.php
@@ -81,7 +81,13 @@ class ConfigEntityQuery extends Sql {
+    if ($field) {

by the look of Drupal\views\Plugin\views\query\Sql::addOrderBy, $alias gets priority over field. Can we change the condition to check $alias first?

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
FileSize
sorting_issue-2877275-4.patch609 bytes

Yes, of course

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks good.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Reviewed & tested by the community » Fixed

Thanks @chr.fritsch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.