This

Inform the user somehow when they are configuring something that changes more than the current page (which is the 80% case). [needs issue]

is listed as a "must have" in #2762505: Introduce "outside in" quick edit pattern to core

There is #2773601: Display "You are now in edit mode" prompt when user enters edit mode

Since in every case the user will be updating something that changes more than the current page should we just explain this in message when entering edit module. If so we could close this issue and do it in #2773601.

Otherwise are we going to have a message on all Settings Tray forms in tray?

Comments

tedbow created an issue. See original summary.

Bojhan’s picture

How do we intent to do this "Apply to all pages" change submit labels or something?

I feel very little for a warning.

yoroy’s picture

@Bojhan so far in core we don’t mention this at all. Want to make sure we know why we must do it here. I assume it’s because the “edit in place” paradigm suggests you’re only editing the thing where you see it. Would be good to be clear on *why* we need this.

tedbow’s picture

tl;dr The message should provided by the individual block form if needed

I agree with @yoroy here. We already have contextual link "Configure Block" on the front end of the site. So really the only difference is the "Quick Edit" link opens in the tray and "Configure Block" opens the full form in a page reload and then take you back to the current page.

In both cases you are access the link on the front end of the site from a contextual link on the block.

I think the only difference is not the block configuration itself but the extra stuff that Settings Tray sometimes includes.

For instance:

  • Branding Block: includes title and slogan of the site with Setting Tray
  • Menu Block: includes disabling, enabling and re-ordering menu items.

I think in both these cases you might want to have some warning that these changes that these are global changes not specific to the block(which is also not specific to the page but that is an existing pattern)

For instance updating the site is going to affect every where the site name is used for example in emails.

A menu might be used in multiple different blocks not just the same block showing up on different page. Maybe I theme would render the menu directly(is that still done?)?

From these examples it seems like if we an extra warning because settings tray is going expose specific related config such Site Name and a Menu then they really need different warnings specific to the type of config that is brought in. The don't really have the same effects.

Right now Settings Tray only provides a specific "off-canvas" form handler for Menu and Branding blocks so these are the only ones that bring in related configuration.

Once this module is stable it would probably make sense for Branding Block Off-canvas form to move to System and Menu to Menu UI. The off-canvas form will just be a different mode that block plugins can provide.

So in the future I think modules in core and contrib will provide their own Off-canvas block if they need to expose related configuration and/or links. In those case they will probably need their own specific warning depending on what they expose.

Bojhan’s picture

Status: Active » Closed (won't fix)

This is a pattern that we have across core (configurations affecting many pages), there is no need to have a special warning here. This was discussed on the product ideas talk with Dries, Angie, Gabor and Ted.

Wim Leers’s picture

Status: Closed (won't fix) » Closed (works as designed)
tedbow’s picture

Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)