Problem/Motivation

When accessing the settings page for Mandrill, a php error is thrown due to an undocumented dependency on dblog.

Proposed resolution

The error is caused by a field description linking through to the error log page. Simply removing this link will resolve the error.

Remaining tasks

Attach patch (coming soon).

User interface changes

A direct link to the error log page will no longer be present in the settings page.

CommentFileSizeAuthor
#7 mandrill_dblog_php_error-2877056-6.patch4.69 KBrjacobsen0
#2 mandrill_dblog_php_error-2877056-2.patch5.04 KBmerauluka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merauluka created an issue. See original summary.

merauluka’s picture

merauluka CreditAttribution: merauluka at Mediacurrent commented
Title: PHP error due on settings page when dblog is disabled » PHP error on settings page when dblog is disabled
FileSize
mandrill_dblog_php_error-2877056-2.patch5.04 KB

Since I was already updating the file, I went ahead and switched out the deprecated l() function called to use Link::fromTextAndUrl() instead.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
rbayliss’s picture

rbayliss CreditAttribution: rbayliss at Last Call Media commented
Status: Needs review » Reviewed & tested by the community

This looks good. Fixes the issue and removes some deprecated code as well.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson as a volunteer commented
Assigned: Unassigned » rjacobsen0
knyshuk.vova’s picture

knyshuk.vova CreditAttribution: knyshuk.vova at Internetdevels, Drupal Ukraine Community commented

The patch looks good and applies successfully. +1 for RTBC.

rjacobsen0’s picture

rjacobsen0 CreditAttribution: rjacobsen0 at ThinkShout for Mailchimp commented
FileSize
mandrill_dblog_php_error-2877056-6.patch4.69 KB

Re rolling this patch because there was a conflict with #2820675: $this->t() should be used instead of t() for Drupal 8 version.

rjacobsen0’s picture

rjacobsen0 CreditAttribution: rjacobsen0 at ThinkShout for Mailchimp commented

So far I have not been able to reproduce the original error. Was it fixed in another ticket??? Is there a setting I'm missing?

joncjordan’s picture

joncjordan CreditAttribution: joncjordan commented

rjacobsen0 to reproduce the error, disable dblog module then visit /admin/config/services/mandrill

brendanthinkshout’s picture

brendanthinkshout CreditAttribution: brendanthinkshout at ThinkShout for Mailchimp commented
Assigned: rjacobsen0 » brendanthinkshout
Status: Reviewed & tested by the community » Fixed
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: brendanthinkshout » Unassigned

FYI the "assigned" field is for indicating you're currently working on something.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.