Problem/Motivation

Things are moving around https://github.com/enyo/dropzone/issues/781 and the functionality is now available for testing. We currently don't offer any resizing at all. The only limit we impose is file size.

Proposed resolution

Start implementing the functionality. Wait committing until a new version of Dropzonejs is released.

Remaining tasks

  1. Test patch with other widgets too (implemented only for file).
  2. Think about possible test coverage.

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Primsi created an issue. See original summary.

Primsi’s picture

Issue summary: View changes
Primsi’s picture

Initial patch

Primsi’s picture

Fixing unwanted change in library file.

Primsi’s picture

Primsi’s picture

Adding additional config parameters and some small docs improvements.

Primsi’s picture

Fixing wrong schema type for quality.

Berdir’s picture

+++ b/dropzonejs.module
@@ -66,5 +66,9 @@ function dropzonejs_library_info_alter(&$libraries, $extension) {
+
+    if ($exif_path = libraries_get_path('exif-js')) {
+      $libraries['exif-js']['js'] = ['/' . $exif_path . '/exif.js' => []];
+    }
   }

doesn't this require the library to be defined in hook_libraries() or something? Maybe that changed..

Looks fine to me other than that and it is working well for us.

Primsi’s picture

Addressing comment from #8. Better yes.

Berdir’s picture

Status: Needs review » Needs work

I think this needs an update for the version number, then lets commit this :)

chr.fritsch’s picture

Status: Needs work » Needs review
FileSize
12.05 KB
2.7 KB

I updated the exif version to 2.3 and added the new schema entries to dropzonejs_media_entity_inline_entity_form as well.

chr.fritsch’s picture

Status: Needs review » Needs work

This also needs an update hook to initialize the new keys in the config.

chr.fritsch’s picture

Status: Needs work » Needs review
FileSize
13.57 KB
1.4 KB

Here is the update path

  • chr.fritsch committed 3adac3b on 8.x-1.x
    Issue #2877034 by Primsi, chr.fritsch: Use dropzonejs client side...
chr.fritsch’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev

Committed to 8.x-1.x. We should also commit it to 2.x

  • chr.fritsch committed 5c294e7 on 8.x-2.x
    Issue #2877034 by Primsi, chr.fritsch: Use dropzonejs client side...
chr.fritsch’s picture

Status: Needs review » Fixed

Pushed to 8.x-2.x as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.