The checkbox for "Create new revision" is hidden by Lightning on all nodes with reasoning that Workbench Moderation forces it to be checked and disables it (so why show it). This shouldn't be done for nodes that are not using Workbench Moderation.

CommentFileSizeAuthor
#5 2876698-5.patch2.07 KBbalsama
#2 2876698.patch1.12 KBbkosborne
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bkosborne created an issue. See original summary.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne at Princeton University commented
Status: Active » Needs review
FileSize
2876698.patch1.12 KB

Here's the fix... sorry no tests.

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Parent issue: » #2875515: [META] Lightning 8.x-2.1.4
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Thanks, @bkosborne! Nice catch. We will need tests, though :)

balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Needs work » Needs review
FileSize
2876698-5.patch2.07 KB

Added a test. Also opened PR to test: https://github.com/acquia/lightning/pull/362

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue tags: -Needs tests
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Reviewed, and it looks good. Ready to merge.

  • balsama committed 0b2b206 on 8.x-2.x authored by bkosborne 
    Issue #2876698 by bkosborne, balsama: "Create new revision" checkbox...
balsama’s picture

balsama
he/him
Primary language English
Location boston
CreditAttribution: balsama at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.