I'm not sure yet if this is a page manager or a display suite issue, I didn't try yet to dig in the code.
Combining display suite with page manager, and implementing a targeted preprocess hook, breaks the output and generates broken html:
Steps to reproduce:
- Install D8.3.3-dev site.
- Install ds-8.x-3.0-rc1 (also with current dev)
- Install page_manager-8.x-4.0-beta2 (also with current dev) and page_manager_ui
- Enable the "node view" page (admin/structure/page_manager) and add a variant of type "Block page". Add the default contexts. On the variant's "Content" add only "Entity view (Content)"
- Visit Manage display for a content type (admin/structure/types/manage/article/display/default)
- Use Select a layout: Display Suite - One column layout
- Generate custom module my_module
- Implement hook:
function my_module_preprocess_ds_1col__node_article_default(&$variables) { }
(just leave the function empty - Create a test node and visit the node/NID page. You will get the broken output.
As stated above, I'm not sure yet if this is a page manager or a display suite issue.
If page manager gets uninstalled, the output (with or without DS's layout) is as expected.
Also if DS gets uninstalled and page manager's variant is enabled, again the output is as expected. If another layout is used (not one of those provided by DS), again the output is as expected. This last point makes me think that it's possibly a DS issue.
I'll come back with further investigation, but if anyone has any idea, please drop it :)
Comment | File | Size | Author |
---|---|---|---|
broken.png | 100.5 KB | efpapado |
Comments
Comment #2
aspilicious CreditAttribution: aspilicious commentedThis is a core bug, it's triggered because DS layouts don't start with 'layout'.
I'll try to find the corresponding core issues.
Comment #3
nagy.balint CreditAttribution: nagy.balint commentedI think I had the same issue.
Any luck finding the core issue?
Comment #4
aspilicious CreditAttribution: aspilicious commentedhttps://www.drupal.org/node/2861840
https://www.drupal.org/node/2862683
Please help them find the problem :)
Comment #5
HongPong CreditAttribution: HongPong as a volunteer and at kor group commentedWould like to know the best preprocess hooks - for example if i want the variable "is_front" to be available in the layouts.
Also this was fixed #2861840: Preprocess functions are not merged when a module registers a theme hook for a theme-provided template
Comment #6
aspilicious CreditAttribution: aspilicious commented