The module has a lot of coding style issues. Here is a patch to fix them all.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

vijaycs85’s picture

Status: Needs review » Needs work
  1. +++ b/config_views.info.yml
    @@ -2,7 +2,6 @@ name: 'Configuration Entity View'
    +  - drupal:views
    

    really? we can do drupal:?

  2. +++ b/config_views.views.inc
    @@ -21,62 +20,59 @@ function config_views_views_data() {
    +        // $data[$table_name]['table']['wizard_id'] = 'config_views_field';.
    

    probably we need to remove this.

chr.fritsch’s picture

Status: Needs work » Needs review
FileSize
23.95 KB
4.04 KB

1. Yes, we should. See https://www.drupal.org/node/2000204
2. Removed whole if block plus the whole ViewsWizard

vijaycs85’s picture

#3.1 awesome.
#3.2 cool.

vijaycs85’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.