CommentFileSizeAuthor
#13 2876366_ui_changes.patch4.32 KBriv16n824
#6 2876366-hostname-exists-fix.patch12.32 KBandriic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

axooh created an issue. See original summary.

Znak’s picture

Znak CreditAttribution: Znak commented
Assigned: Unassigned » Znak
psiska’s picture

psiska CreditAttribution: psiska at Gridonic commented

@Znank I'm getting the same issue. Are we missing something in configuring this module in D8? /cc @itsekhmistro

A related issue might be this one: https://www.drupal.org/node/2846253

netw3rker’s picture

netw3rker CreditAttribution: netw3rker commented

I just ran into the same problem. It pretty much is an issue with the domain module. I had to hack domain to force it to work. I'd submit a patch to domain, but I'm pretty sure that they aren't going to want to add "creating duplicate hosts" to their roadmap.

@znak I'm not 100% positive that country path's are being handled correctly within the domain module. I suspect that this module is really supposed to implement it's own domain class that validates differently, and maybe inherits from the/a primary domain rather than requiring multiple standalone domain entries.

One particular problem/usecase is: it will be a total pain to manage this as configuration and switch between environments. lets say I have 50 countries. I'd have to reconfigure all 50 of them to use my staging environment's domain, vs if they just inherited from a primary, then there's just one to be concerned about.

axooh’s picture

axooh CreditAttribution: axooh at Gridonic commented

@netw3rker: Thanks for your feedback on this. It would be great, if you can submit a patch for the Domain module, even though it probably wouldn't be accepted by the domain access maintainers. But for us, this would be a great help!

andriic’s picture

andriic CreditAttribution: andriic at Adyax commented
FileSize
2876366-hostname-exists-fix.patch12.32 KB

Check this patch. It will allow you to add similar hostnames with different country paths.

Country path textfield disabled, you should specify it in Hostname field, e.g.: example.com/usa

Also, Country path values added to /admin/config/domain page.

axooh’s picture

axooh CreditAttribution: axooh commented

Patch works for me, thanks!

itsekhmistro’s picture

itsekhmistro CreditAttribution: itsekhmistro at Adyax commented
Status: Active » Needs review

Thank you. Reviewing the patch

Ivo.Radulovski’s picture

Ivo.Radulovski CreditAttribution: Ivo.Radulovski as a volunteer and at trio-group I.AM commented

we will also review the patch today

itsekhmistro’s picture

itsekhmistro CreditAttribution: itsekhmistro at Adyax commented

The patch applied. Andrey, thank you for the great work! Thanks everyone involved for help.

The issue is fixed however I think we need to work to improve UI:
* Hide country_path field
* Display country_path suffix along with Hostname ( in the same input) in Edit domain form
* Display country_path suffix along with Hostname on Domains list dashboard.

itsekhmistro’s picture

itsekhmistro CreditAttribution: itsekhmistro at Adyax commented
Status: Needs review » Fixed
riv16n824’s picture

riv16n824 CreditAttribution: riv16n824 at Adyax commented
Issue summary: View changes
FileSize
2876366_ui_changes.patch4.32 KB

The issue is fixed however I think we need to work to improve UI:
* Hide country_path field
* Display country_path suffix along with Hostname ( in the same input) in Edit domain form
* Display country_path suffix along with Hostname on Domains list dashboard.

Here is a patch with UI changes.

itsekhmistro’s picture

itsekhmistro CreditAttribution: itsekhmistro at Adyax commented

Hi,

> https://www.drupal.org/node/2876366#comment-12143260

please move the last patch and details into a separate issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.