Make Drupal.tableDrag.restripeTable 10x faster

Oh! good catch.

No issue here. Doesn't change the logic, just separate selection and initial filtering.

+++ b/core/misc/tabledrag.js
@@ -1162,10 +1162,11 @@
-    $(this.table).find('> tbody > tr.draggable:visible, > tr.draggable:visible')
-      .removeClass('odd even')
-      .filter(':odd').addClass('even').end()
-      .filter(':even').addClass('odd');
+    // This is performance optimized code. Benchmark is required on code refactoring.
+    $(this.table).find('> tbody > tr.draggable, > tr.draggable')
+      .filter(':visible')
+      .filter(':odd').removeClass('odd').addClass('even').end()
+      .filter(':even').removeClass('even').addClass('odd');

This needs some 80 char wrapping which I was about to do myself, but better yet can we explain the added comment a bit better. I would say lot of things in PHP/JS are performance optimized and we don't say this in code comments :)

I would personally drop it, we usually don't explain these tricks :)

:)

Thanks, committed to 8.4.x and cherry-picked to 8.3.x given that this was a simple self-contained performance improvement that has no side effect whatsoever :)

NICE.