Follow up to #2863267: Convert web tests of views

The AJAX part of the test just takes a stab at testing AJAX pagination. We have extensive coverage for that in \Drupal\Tests\views\FunctionalJavascript\PaginationAJAXTest, so that part can be removed here.

The remaining coverage in PaginationAJAXTest::testAjaxView has some merit since it analyses the ajax data structure in the response, so I'd say lets keep that.

\Drupal\Tests\views\Functional\ViewAjaxTest::testNonAjaxViewViaAjax needs to be refactored to use getHttpClient to replace drupalPost. This test certainly needs to stay in since it test a security fix.

CommentFileSizeAuthor
#6 2876209-6.patch5.41 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Lendude created an issue. See original summary.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

ApacheEx’s picture

Issue tags: +LutskGSW18

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Lendude’s picture

Title: Convert \Drupal\views\Tests\ViewAjaxTest to a javascript test » Convert \Drupal\views\Tests\ViewAjaxTest to a BrowserTestBase test
Issue summary: View changes
Status: Active » Needs review
FileSize
5.41 KB

The AJAX part of the test just takes a stab at testing AJAX pagination. We have extensive coverage for that in \Drupal\Tests\views\FunctionalJavascript\PaginationAJAXTest, so that part can be removed here.

The remaining coverage in testAjaxView has some merit since it analyses the ajax data structure in the response, so I'd say lets keep that.

\Drupal\Tests\views\Functional\ViewAjaxTest::testNonAjaxViewViaAjax needs to be refactored to use getHttpClient to replace drupalPost. This test certainly needs to stay in since it test a security fix.

ApacheEx’s picture

Status: Needs review » Reviewed & tested by the community

This sounds reasonable and done with minimal changes.
+1 to RTBC

  • catch committed d136825 on 8.7.x
    Issue #2876209 by Lendude: Convert \Drupal\views\Tests\ViewAjaxTest to a...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!

  • catch committed 90779e2 on 8.6.x
    Issue #2876209 by Lendude: Convert \Drupal\views\Tests\ViewAjaxTest to a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.