Follow up to #2863267: Convert web tests of views
The AJAX part of the test just takes a stab at testing AJAX pagination. We have extensive coverage for that in \Drupal\Tests\views\FunctionalJavascript\PaginationAJAXTest
, so that part can be removed here.
The remaining coverage in PaginationAJAXTest::testAjaxView has some merit since it analyses the ajax data structure in the response, so I'd say lets keep that.
\Drupal\Tests\views\Functional\ViewAjaxTest::testNonAjaxViewViaAjax
needs to be refactored to use getHttpClient to replace drupalPost. This test certainly needs to stay in since it test a security fix.
Comment | File | Size | Author |
---|---|---|---|
#6 | 2876209-6.patch | 5.41 KB | Lendude |
Comments
Comment #3
ApacheEx CreditAttribution: ApacheEx commentedComment #6
LendudeThe AJAX part of the test just takes a stab at testing AJAX pagination. We have extensive coverage for that in
\Drupal\Tests\views\FunctionalJavascript\PaginationAJAXTest
, so that part can be removed here.The remaining coverage in testAjaxView has some merit since it analyses the ajax data structure in the response, so I'd say lets keep that.
\Drupal\Tests\views\Functional\ViewAjaxTest::testNonAjaxViewViaAjax
needs to be refactored to use getHttpClient to replace drupalPost. This test certainly needs to stay in since it test a security fix.Comment #7
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Internetdevels, Drupal Ukraine Community commentedThis sounds reasonable and done with minimal changes.
+1 to RTBC
Comment #9
catchCommitted/pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!