Follow-up to #2869874: Webform should use libraries available via secure download

Problem/Motivation

Webform module needs to include a basic CKEditor which support the basic image and link dialog plugins which are not include Drupal core custom version of the CKEditor

Proposed resolution

Correctly use the CKEDITOR.plugins.addExterna to add the need plugins and stop download a duplicate copy of the CKEditor.

CommentFileSizeAuthor
#9 stop_downloading_a_full-2875878-9.patch14.12 KBjrockowitz
#7 stop_downloading_a_full-2875878-6.patch12.21 KBjrockowitz
#3 stop_downloading_a_full-2875878-2.patch10.61 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

  • jrockowitz committed d1e1294 on 2875878-ckeditor-plugins 
    Issue #2875878: Stop downloading a full copy of CKEditor and only...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Needs review
FileSize
stop_downloading_a_full-2875878-2.patch10.61 KB

Status: Needs review » Needs work

The last submitted patch, 3: stop_downloading_a_full-2875878-2.patch, failed testing.

  • jrockowitz committed 879a6d1 on 2875878-ckeditor-plugins 
    Issue #2875878: Stop downloading a full copy of CKEditor and only...

  • jrockowitz committed 99487e4 on 2875878-ckeditor-plugins 
    Issue #2875878: Stop downloading a full copy of CKEditor and only...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
stop_downloading_a_full-2875878-6.patch12.21 KB

  • jrockowitz committed 31e4c4e on 2875878-ckeditor-plugins 
    Issue #2875878: Stop downloading a full copy of CKEditor and only...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
stop_downloading_a_full-2875878-9.patch14.12 KB

  • jrockowitz committed b70a648 on 8.x-5.x 
    Issue #2875878 by jrockowitz: Stop downloading a full copy of CKEditor...

Status: Needs review » Needs work

The last submitted patch, 9: stop_downloading_a_full-2875878-9.patch, failed testing.

  • jrockowitz committed fd52aad on 8.x-5.x 
    Issue #2875878: Stop downloading a full copy of CKEditor and only...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.