This task is for a new student in MD Systems, don't do it if it was not assigned to you.

Problem/Motivation

Currently we have the removal submit button with a "Remove selected" label as shown on the image.

We want to be more specific about the removal for the item.

Proposed resolution

Change the label of the submit to "Remove selected item" and fix failing test after accordingly.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 edit_remove_label-2875142-3.patch1.01 KBbasti.diaaz
#2 edit_label_remove-2875142-1.patch0 bytesbasti.diaaz
remove-selected.png29.74 KBGinovski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ginovski created an issue. See original summary.

basti.diaaz’s picture

basti.diaaz CreditAttribution: basti.diaaz as a volunteer commented
Assigned: Unassigned » basti.diaaz
FileSize
edit_label_remove-2875142-1.patch0 bytes

Assigned.

basti.diaaz’s picture

basti.diaaz CreditAttribution: basti.diaaz as a volunteer commented
FileSize
edit_remove_label-2875142-3.patch1.01 KB
Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Active » Needs review

The last submitted patch, 2: edit_label_remove-2875142-1.patch, failed testing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

  • Berdir committed 57ff08f on 8.x-1.x authored by basti.diaaz 
    Issue #2875142 by basti.diaaz, Ginovski: Change "remove selected" submit...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Reviewed & tested by the community » Fixed

Overlooked this, committing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.