Updating from 1.14 to 1.15 broke all my webforms.

Trying to fill out the forms returns HTTP 500 errors.

Using PHP 5.6

Is anyone else getting this problem?

Downgrading to 1.14 solved the problem.

Comments

vchen created an issue. See original summary.

Liam Morland’s picture

I haven't seen or hear of this problem. We're using PHP 5.6. You could use git bisect to figure out which commit it causing the problem.

lustratus’s picture

I was having this problem as well; I don't recall if I had just updated webmin or not, although I did run several updates that day. I tracked it down to a few lines in webform_rules.rules.inc.

I'm using PHP 5.6 as well.

I had to make these changes:
if (empty($submission) || !$submission[$first_key]->nid ) {
changed to:
if (empty($submission) || empty(array_values($submission)[0]->nid)) {

I also made a similar change a few lines down:
if(!empty($selection['webform-client-form-' . $submission[$first_key]->nid )){
changed to:
if(!empty($selection['webform-client-form-' . array_values($submission)[0]->nid])){

lias’s picture

I'm experiencing the same issue with 7x4-15 and getting intermittent user feedback that they submit the form and get the 500 error. Using PHP 5.6 as well.

I have forms set to email the submissions and do receive the submitted form but the user ends up duplicating the submission because they think it failed.

@vchen - how did you downgrade to 4.14? I wasn't sure if the 4.15 updated the database and would break my forms.

@jeeberpow - I'm not seeing that webform_rules.rules.inc in the webform 4.15 module directory. Where exactly is this file?

vchen’s picture

@Isabug - I probably deleted 4.15 and redownloaded 4.14 and run drush updatedb.

I forgot about this issue actually and had updated back to 4.15 a while ago and somehow the problem isn't being reported anymore.

lias’s picture

Thanks for the update @vchen.

Unfortunately I'm still experiencing it but it's not consistent with the error at all, - I'll try deleting 4.15 on my dev site and replacing with 4.14 and see what happens.

lias’s picture

To follow up, I downgraded to version 4.14 and the error disappeared.

Liam Morland’s picture

Priority: Major » Normal

It would be great if you could use git bisect to identify the problem commit.