Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is coding standard issue in the following project.
git clone --branch 8.x-2.x https://git.drupal.org/project/payment.git
Please do check attached file.
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff_5-7.txt | 51.1 KB | adityasingh |
#7 | 2874906-7.patch | 356.68 KB | adityasingh |
| |||
#5 | coding-standard-2874906-5.patch | 347.24 KB | rajandro |
#3 | pending_coding_standard_errors.txt | 5.61 KB | rajandro |
#3 | coding-standard-2874906-3.patch | 350.94 KB | rajandro |
Comments
Comment #2
rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedSince this is a very old issue, so adding the new Coding standard violation message here that needs to address.
Comment #3
rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedAdding a patch to fix for the coding standard issue. Except for a few commenting and depreciation errors rest of the issue has been resolved. For the pending scenario as mentioned in the attached file, we need to decide we will remove the unnecessary parameter or not.
Comment #4
BerdirThis has syntax errors and will require a reroll now.
Comment #5
rajandro CreditAttribution: rajandro as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedRe-rolled the patch and checked the module for any syntax error, didn't find any for the new patch. However, we still need to address the comment of #3
This patch address array format, spacing issue. However, I believe it's better to split this ticket per rule basis and fix it accordingly.
After this patch, if it still fails I will break it into child issues based on rules.
Comment #6
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedWorking on this.
Comment #7
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedFixed as per drupal coding standard
Comment #8
urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commentedComment #10
BerdirCommitted.
Comment #11
apaderno