CommentFileSizeAuthor
#4 2874166-3.patch2.48 KBRajab Natshah
#2 2874166-2.patch2.49 KBRajab Natshah
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajabNatshah created an issue. See original summary.

Rajab Natshah’s picture

FileSize
2.49 KB
Rajab Natshah’s picture

Assigned: Rajab Natshah » Unassigned
Status: Needs work » Needs review
Rajab Natshah’s picture

FileSize
2.48 KB

  • 283e701 committed on 8.x-1.x
    Issue #2874166 by RajabNatshah:
    1. Implement hook_requirements() on...
israelshmueli’s picture

Thank you for the patch.
The last commit, few minites ago applied it.
Much appreciated.

israelshmueli’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Grate work

I wish if we could have the library directly in the module as an asset.

Drupal core team are committing plugins by having CKEditor plugins in the core/assets/vendor/ckeditor/plugins
Some modules commit the CKEditor plug in library in the /js/plugins in their module.
I did that in CKEditor Anchor Link - For Drupal 8

Had some issues with bidi library:

For example doing the following will not work in the drupal-org.mak file for my custom profile or distribution:

libraries[bidi][download][type] = get
libraries[bidi][download][url] = "http://download.ckeditor.com/bidi/releases/bidi_4.6.2.zip"
libraries[bidi][destination] = "libraries"

#2874359: CKEditor - BiDi (Text Direction)
Not sure if they will add the CKEditor - BiDi (Text Direction) into the Drupal.org Library Packaging Whitelist

No issues with the composer way.

israelshmueli’s picture

Sure, Including the JS plugin with this module is much better experience to site builders.

And today, thanks to your successful effort to whitelist the BiDi external plugin, it made possible.

So now it is listed on the Packaging whitelist URLs - https://www.drupal.org/packaging-whitelist .

I plan, during the next few days, to create version 2 of this module with the plugin included. I will let you know when released.

  • 283e701 committed on 8.x-2.x
    Issue #2874166 by RajabNatshah:
    1. Implement hook_requirements() on...
israelshmueli’s picture

The bidi plugin library is now part of the module, thanks RajabNatshah.

Rajab Natshah’s picture

Thanks Israelshmueli,
We are using the module in Varbase Editor and Varbase, As we are maintaining the profile with LTR and RTL in all parts.
An update after the release is a must.

I love Open Source :)
Thank you again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.