Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2874166-3.patch | 2.48 KB | Rajab Natshah |
Comment | File | Size | Author |
---|---|---|---|
#4 | 2874166-3.patch | 2.48 KB | Rajab Natshah |
Comments
Comment #2
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #3
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #4
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #6
israelshmueli CreditAttribution: israelshmueli as a volunteer commentedThank you for the patch.
The last commit, few minites ago applied it.
Much appreciated.
Comment #7
israelshmueli CreditAttribution: israelshmueli as a volunteer commentedComment #8
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedGrate work
I wish if we could have the library directly in the module as an asset.
Drupal core team are committing plugins by having CKEditor plugins in the core/assets/vendor/ckeditor/plugins
Some modules commit the CKEditor plug in library in the /js/plugins in their module.
I did that in CKEditor Anchor Link - For Drupal 8
Had some issues with bidi library:
For example doing the following will not work in the drupal-org.mak file for my custom profile or distribution:
#2874359: CKEditor - BiDi (Text Direction)
Not sure if they will add the CKEditor - BiDi (Text Direction) into the Drupal.org Library Packaging Whitelist
No issues with the composer way.
Comment #9
israelshmueli CreditAttribution: israelshmueli as a volunteer commentedSure, Including the JS plugin with this module is much better experience to site builders.
And today, thanks to your successful effort to whitelist the BiDi external plugin, it made possible.
So now it is listed on the Packaging whitelist URLs - https://www.drupal.org/packaging-whitelist .
I plan, during the next few days, to create version 2 of this module with the plugin included. I will let you know when released.
Comment #11
israelshmueli CreditAttribution: israelshmueli as a volunteer commentedThe bidi plugin library is now part of the module, thanks RajabNatshah.
Comment #12
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedThanks Israelshmueli,
We are using the module in Varbase Editor and Varbase, As we are maintaining the profile with LTR and RTL in all parts.
An update after the release is a must.
I love Open Source :)
Thank you again.