I was shocked to see that Node module didn't have a listed maintainer in MAINTAINERS.txt. As such a cornerstone of Drupal this seems crazy.

I would like to put my name forward for the role, but would be equally happy for someone else to take the role. In my work with content moderation and the workflow initiative, as well as maintainer of Statistics I hit many core issues for Node. There really should be someone who is at least keeping an eye on all these issues and taking on maintainer duty.

CommentFileSizeAuthor
#2 2874043-2.patch343 bytesnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

timmillwood created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Active » Needs review
FileSize
2874043-2.patch343 bytes

+1 if you're open to maintain it. It would be great if there would be more than 1 maintainer it would divide the efforts in cleaning the issue queue :P

//Naveen

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Three cheers for @timmillwood! :)

Preemptively RTBC on the quite likely condition that the tests pass.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented

+1 from me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2874043-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Needs review

Et tu, Drupal CI?

Status: Needs review » Needs work

The last submitted patch, 2: 2874043-2.patch, failed testing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio at DiD Agency commented

On mobile or I would make an issue, but that is the second time today I have seen those fails on unrelated issues.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar as a volunteer and at Globant commented

This was committed (and revered by @alexpott already) https://www.drupal.org/node/2863416#comment-12062889

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

Thanks for your support

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Assigned: Unassigned » Dries

As per https://www.drupal.org/governance/core#bdfl

since the BDFL making every decision would be highly un-scalable, in practice decisions are spread across multiple maintainers. The BDFL appoints and replaces those maintainers

So assigning to Dries. I don't think he would have any complaints, but that is our documented process :)

  • xjm committed 21f49e4 on 8.4.x 
    Issue #2874043 by naveenvalecha, timmillwood, phenaproxima, mpdonadio:...

  • xjm committed 5754842 on 8.3.x 
    Issue #2874043 by naveenvalecha, timmillwood, phenaproxima, mpdonadio:...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

So that was an outdated page. As per https://www.drupal.org/contribute/core/maintainers which is the current page:

If the change involves adding a new subsystem maintainer, a product, framework, or release manager must approve or refuse it (depending on the subsystem). (Any may commit a change to remove a subsystem maintainer at that maintainer's own request.)

I added a drupal.org redirect from the old URL to the new URL, so people don't get confused :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Assigned: Dries » Unassigned
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.4.x-dev » 8.3.x-dev
Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Normally we'd want explicit confirmation on the issue of the maintainer agreeing to the responsibilities in:
https://www.drupal.org/contribute/core/maintainers#subsystem

However, Tim already maintains other subsystems so presumably he did that the first time. :)

Any full committer can add a subsystem maintainer per:

If the change involves adding a new subsystem maintainer, a product, framework, or release manager must approve or refuse it (depending on the subsystem). (Any may commit a change to remove a subsystem maintainer at that maintainer's own request.)

http://cgit.drupalcode.org/governance/tree/drupal-core.html#n74

So I can sign off on this too and I think it's a great choice. Thanks @timmillwood!

@timmillwood already had "maintain issues" permission, but had not correctly been granted access for g.d.o/core. So I've added that. (@timmillwood, so you can post announcements about the subsystem and such.)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

Thanks @Gábor Hojtsy & @xjm!

I'm already tracking new "Node System" issues that are opened, but please loop me in if there is anything you think might be relevant.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Thanks Tim!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.