Add Change record to @deprecated in UrlGeneratorTrait.php

CommentFileSizeAuthor
#4 2873844_4.patch827 bytesjosephcheek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josephcheek created an issue. See original summary.

tachiinii’s picture

tachiinii CreditAttribution: tachiinii as a volunteer commented
Title: Add Change record to @deprecated in UrlGeneratorTrait.php » Add Change record to @deprecated in UrlGeneratorTrait
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
josephcheek’s picture

josephcheek
Location Provo, UT
CreditAttribution: josephcheek at TATA Consultancy Services commented
Status: Active » Needs review
FileSize
2873844_4.patch827 bytes

patch attached.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
CreditAttribution: sorabh.v6 at Acro Commerce commented
Assigned: Unassigned » sorabh.v6
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
CreditAttribution: sorabh.v6 at Acro Commerce commented

@see have been added to trait UrlGeneratorTrait and function url().

I'm setting to RTBC. Thanks All

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
CreditAttribution: sorabh.v6 at Acro Commerce commented
Assigned: sorabh.v6 » Unassigned
Status: Needs review » Reviewed & tested by the community
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Needs review

Did someone verify that the url() method depreciation is the same as the depreciation of the whole trait? We don't have depreciations on any of the other methods.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Needs work

There's actually quite a bit of work needed here to reference All The Things(tm) that got deprecated with that CR: https://www.drupal.org/node/2614344. Please review the notes in in the parent meta #2873705: Add change records to all @deprecated code to see how to go about doing that.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jpmelguizo’s picture

jpmelguizo CreditAttribution: jpmelguizo commented
Issue tags: +SprintWeekend2018

Hey @jmsosso and I will work in this issue for the Sprint Weekend 2018

jpmelguizo’s picture

jpmelguizo CreditAttribution: jpmelguizo commented
Status: Needs work » Needs review

We checked that the deprecated tag was added to the method as well as the trait in the same issue #2606396: mark \Drupal\Core\Routing\LinkGeneratorTrait and \Drupal\Core\Routing\UrlGeneratorTrait as deprecated and it's referencing the same change record added in the previous patch. Deprecated tags were added to LinkGeneratorTrait and its method too but this issue mentions only UrlGeneratorTrait so the scope should be that.

I believe the previous patch from #4 is fine and adds the most relevant change record available.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Title: Add Change record to @deprecated in UrlGeneratorTrait » Add Change record to @deprecated in UrlGeneratorTrait and LinkGeneratorTrait, etc.
Status: Needs review » Needs work

Let's group a few more things related to the CR into a single patch. It will make things easier for the committers.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Closed (outdated)

Thanks to everyone who worked on this.

The work here relates to a change that was removed in Drupal 9.0.0. Drupal 8 and Drupal 9.0.0 are no longer supported which means this is outdated.

Therefore, closing as outdated.

Thanks!