Currently the .info.yml file of all core themes contains the line:

package: Core

What is the purpose of this line? /appearance does not display content in packages like /modules does.

Is this in error?

CommentFileSizeAuthor
#4 remove_package-2873834-4.patch2.31 KBNonProfit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NonProfit created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

That's a good question... I don't know. It could allow the interface to group themes together but as you mentioned it doesn't do that.

Maybe since you have this as a Bug report, you'd like to propose a way forward to resolve it in the issue summary and re-title?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

Just for reference it's documented here and any proposed changes would need to update this doc as well. https://www.drupal.org/node/2349827

NonProfit’s picture

NonProfit CreditAttribution: NonProfit at GoGrow.org commented
Title: What is the purpose of setting Package in core themes? » Remove Package from core theme .info files.
Status: Active » Needs review
FileSize
remove_package-2873834-4.patch2.31 KB

Patch attached which removes package from bartik.info.yml, classy.info.yml, seven.info.yml, stable.info.yml, and stark.info.yml.

Dinesh18’s picture

Dinesh18 CreditAttribution: Dinesh18 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I have applied the patch and it is working as expected.
Changing the status to RTBC.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Needs review

Why is it a problem that the info files have this line? What problem does this cause?

NonProfit’s picture

NonProfit CreditAttribution: NonProfit at GoGrow.org commented

Hello Dinesh18,

Thank you for taking the time to test the patch.

Hello Gábor,

Thanks for your comment. I can't say that it poses a problem, but as far as I can tell, the lines do not benefit us either. If they serve no purpose, why include them?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Is this data not exposed / accessible on the API? Looks to me like if we can use this data to tell core themes from contrib themes it is very useful to have.

NonProfit’s picture

NonProfit CreditAttribution: NonProfit at GoGrow.org commented
Status: Needs review » Closed (won't fix)

Gábor, point taken. Thanks for your insight.