Proposed resolution

Hi, i optimize the code in FormModeManagerLocalAction

CommentFileSizeAuthor
#6 interdiff-2873814-6.txt727 byteswoprrr
#6 refacto_code_of-2873814-6.patch14.69 KBwoprrr
#5 refacto_code_of-2873814-5.patch14.69 KBwoprrr
#5 interdiff-2873814.txt9.12 KBwoprrr
#2 refacto_code_on-2873814-2.patch5.38 KBsallakane
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sallakane created an issue. See original summary.

sallakane’s picture

sallakane CreditAttribution: sallakane at NeoLynk for Carrefour commented
FileSize
refacto_code_on-2873814-2.patch5.38 KB
sallakane’s picture

sallakane CreditAttribution: sallakane at NeoLynk for Carrefour commented
Status: Active » Needs review
woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Title: Refacto code on FormModeManagerLocalAction » Refacto code of FormModeManagerLocal (links)
Issue tags: +refactoring

I add with your patch a localTasks refactoring.

woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
FileSize
interdiff-2873814.txt9.12 KB
refacto_code_of-2873814-5.patch14.69 KB
woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Needs review » Reviewed & tested by the community
FileSize
refacto_code_of-2873814-6.patch14.69 KB
interdiff-2873814-6.txt727 bytes

There is the patch to fix fatal + I have processed an full pass of all functionalities of module all seems to be good.

  • woprrr committed 7d03687 on 8.x-1.x authored by sallakane 
    Issue #2873814 by woprrr, sallakane: Refacto code of...
woprrr’s picture

woprrr CreditAttribution: woprrr as a volunteer and at NeoLynk commented
Status: Reviewed & tested by the community » Fixed

Merged Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.