Add Change record to @deprecated for LinkGeneratorTrait in LinkGeneratorTrait.php

CommentFileSizeAuthor
#3 2873806_2.patch789 bytesjosephcheek
#2 2873806_1.patch487 bytesjbaxton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jbaxton created an issue. See original summary.

jbaxton’s picture

jbaxton CreditAttribution: jbaxton commented
Status: Active » Needs review
FileSize
2873806_1.patch487 bytes

Add Change record to @deprecated for LinkGeneratorTrait in LinkGeneratorTrait.php

josephcheek’s picture

josephcheek
Location Provo, UT
CreditAttribution: josephcheek at TATA Consultancy Services commented
FileSize
2873806_2.patch789 bytes

added @see for deprecated function l() as well.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Title: Add Change record to @deprecated for LinkGeneratorTrait in LinkGeneratorTrait.php » Add Change record to @deprecated for LinkGeneratorTrait
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
CreditAttribution: sorabh.v6 at Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

@see have been added to LinkGeneratorTrait and l(). I confirm that no other @deprecated without @see is left in LinkGeneratorTrait.php

I'm setting to RTBC. Thanks All

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

👍

  • catch committed 314e446 on 8.4.x 
    Issue #2873806 by jbaxton, josephcheek: Add Change record to @deprecated...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children