Problem/Motivation

Overriding the PanelsIPEPageController routes is difficult, because the method return the instantiated JsonResponse.

Proposed resolution

Break the current route methods into two methods, the first returns an array, and the second returns the JsonResponse. With this delineation, an overriding class could override the data method, alter the data, and then let it be returns by the Json method.

Remaining tasks

review code and merge

User interface changes

none

API changes

Existing API's don't change but new methods are created.

Data model changes

none

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

douggreen created an issue. See original summary.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

This looks great to me. Leaves the existing methods in place, and allows more flexibility

  • japerry committed a0196e7 on 8.x-4.x authored by douggreen
    Issue #2873681 by douggreen: Make PanelsIPEPageController more...
japerry’s picture

Status: Reviewed & tested by the community » Fixed

Looks good. commited!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.