Add missing schema for views.filter_value.comment_ces_last_updated

We need a functional test to demonstrate this problem.

Steps I tried to reproduce:

• 8.4.x latest HEAD, minimal install with datetime and Views modules enabled
• Add content type
• Add a datetime field to the content type
• Create a new View
• Add the datetime field as an exposed filter
• Save the View
• No problem

Adding config file of the View I used

@jncruces thanks for reporting back your findings.

I have the same problem with Drupal Core 8.4.0

I don't think I have the same closed-issue-reason like @jncruces.

The website encountered an unexpected error. Please try again later.InvalidArgumentException: The configuration property display.default.display_options.filters.field_example_target_id.value.60072 doesn't exist. in Drupal\Core\Config\Schema\ArrayElement->get() (line 76 of core/lib/Drupal/Core/Config/Schema/ArrayElement.php

Drupal\Core\Config\StorableConfigBase->castValue('display.default.display_options.filters.field_example_target_id.value.60072', '60072') (Line: 211)
Drupal\Core\Config\StorableConfigBase->castValue('display.default.display_options.filters.field_example_target_id.value', Array) (Line: 211)
Drupal\Core\Config\StorableConfigBase->castValue('display.default.display_options.filters.field_example_target_id', Array) (Line: 211)
Drupal\Core\Config\StorableConfigBase->castValue('display.default.display_options.filters', Array) (Line: 211)
Drupal\Core\Config\StorableConfigBase->castValue('display.default.display_options', Array) (Line: 211)
Drupal\Core\Config\StorableConfigBase->castValue('display.default', Array) (Line: 211)
Drupal\Core\Config\StorableConfigBase->castValue('display', Array) (Line: 212)
Drupal\Core\Config\Config->save() (Line: 280)
Drupal\Core\Config\Entity\ConfigEntityStorage->doSave('timeline', Object) (Line: 392)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 259)
Drupal\Core\Config\Entity\ConfigEntityStorage->save(Object) (Line: 377)
Drupal\Core\Entity\Entity->save() (Line: 637)
Drupal\Core\Config\Entity\ConfigEntityBase->save() (Line: 989)
Drupal\views_ui\ViewUI->save() (Line: 324)
Drupal\views_ui\ViewEditForm->save(Array, Object)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder->processForm('view_edit_form', Array, Object) (Line: 314)
Drupal\Core\Form\FormBuilder->buildForm('view_edit_form', Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'edit', Array) (Line: 226)
Drupal\views_ui\Controller\ViewsUIController->edit(Object, 'block_1')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 576)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 153)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 60)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 657)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

@handkerchief does this happen on a clean D8 install too? Can you provide a yml file of the View in question? Or give some steps to reproduce this on a clean D8 install?

So I found the "problem"... and yes, it's an individual problem.

I'm using this "trick" for selecting nodes in my exposed filter like taxonomies.
https://drupal.stackexchange.com/a/231771

The plugin is almost a duplicate from the taxonomy filter: https://gist.github.com/StryKaizer/ae1cb9abc4844a9e7ac12317a9d84a78

With this plugin (which should be also included in core - I mean the functionallity) the error appears. So I suppose the taxonomy filter had this problem too. If l knew what was changed there, I can adapt this for the plugin.

Any advice?

So you need to have a config schema for all Views filter plugins, otherwise Drupal has no idea how to save your data to config (it defaults to a string value, but that is not what you are using, hence the fail).

See core/modules/views/config/schema/views.filter.schema.yml and core/modules/taxonomy/config/schema/taxonomy.views.schema.yml for some examples.

something like this would do unless you store more data then the base taxonomy filter:

views.filter.your_plugin_id_here:
  type: views.filter.taxonomy_index_tid
  label: 'Taxonomy term ID extended'

@Lendude Thank you for the awesome and quick support. I wish other maintainers would react so quickly. Have a nice day.

I had this error:
InvalidArgumentException: The configuration property display.page_2.display_options.filters.title.value.value doesn't exist. in Drupal\Core\Config\Schema\ArrayElement->get() (line 76 of D:\phptest\theideaproject\web\core\lib\Drupal\Core\Config\Schema\ArrayElement.php).

When I tried to save my views.
I have two node types. 1 has reference to the other one. I created an exposed filter with count aggregation, which works fine in preview. But when I tried to save, I get fatal error.

I get the some problem when update from drupal 8.3.7 to 8.4.2.

views module
Update revision_metadata_fields

Failed: InvalidArgumentException: The configuration property display.default.display_options.filters.field_tip_target_id.value.14 doesn't exist.
in Drupal\Core\Config\Schema\ArrayElement->get() (line 76 у /site/core/lib/Drupal/Core/Config/Schema/ArrayElement.php).

View are no more update, they show the some content as in past. If I add now node its is not posible to see in view.

I'm experiencing this, too, with any View that uses the core taxonomy_index_tid filter . Happens during an update from 8.3.x -> 8.4.x

The schema is properly defined for this filter. It should be a sequence.

Here's what core exports for one of my Views, using this filter:

      field_term_section_target_id:
          id: field_term_section_target_id
          table: node__field_term_section
          field: field_term_section_target_id
          relationship: none
          group_type: group
          admin_label: ''
          operator: or
          value:
            26: 26
          group: 1
          exposed: false
          expose:
            operator_id: ''
            label: ''
            description: ''
            use_operator: false
            operator: ''
            identifier: ''
            required: false
            remember: false
            multiple: false
            remember_roles:
              authenticated: authenticated
            reduce: false
          is_grouped: false
          group_info:
            label: ''
            description: ''
            identifier: ''
            optional: true
            widget: select
            multiple: false
            remember: false
            default_group: All
            default_group_multiple: {  }
            group_items: {  }
          reduce_duplicates: false
          type: select
          limit: true
          vid: section
          hierarchy: false
          error_message: true
          plugin_id: taxonomy_index_tid

Looks fine to me.

But Sequence::get() (actually ArrayElement::get() ) does the following:

  public function get($name) {
    $parts = explode('.', $name);
    $root_key = array_shift($parts);
    $elements = $this->getElements();
    if (isset($elements[$root_key])) {
      $element = $elements[$root_key];
      // If $property_name contained a dot recurse into the keys.
      while ($element && ($key = array_shift($parts)) !== NULL) {
        if ($element instanceof TypedConfigInterface) {
          $element = $element->get($key);
        }
        else {
          $element = NULL;
        }
      }
    }
    if (isset($element)) {
      return $element;
    }
    else {
      throw new \InvalidArgumentException("The configuration property $name doesn't exist.");
    }
  }

That method receives "display.default.display_options.filters.field_term_section.value.26" as an argument.

When we get down to the term ID value, we get a StringData, which is not an instance of TypedConfigInterface... and that's where we get InvalidArgumentException.

I'm not sure where the actual bug is:
- Is Views exporting this one wrong? (not that I can tell)
- Is this related to the update? Doesn't look that any related code was changed...
- Should StringData be valid as well as TypedConfigInterface?
- Should StorableConfigBase::castValue() check the schema to see if it's a sequence, and simplify the value somehow?

I discovered this error during an update, when it tried to run views_post_update_revision_metadata_fields(). That function just runs save() on all your extant Views. I do not see an error when I save the View in the UI, however.

TO REPRODUCE:

* fresh install of Drupal 8.3.x, "standard" profile
* create a term in the "tags" vocabulary
* create a View of nodes, with a taxonomy_term_id filter for this term ("Content: tags: test term")
* save the View.
* update to Drupal 8.4.x

Further debugging got me to the root of this: search_api_taxonomy module overrides the definition for the taxonomy_index_tid incorrectly. This is fixed in #2917399: Missing / broken handler when adding a filter for a field , which is included in search_api-8.x-1.6 .

Closing this ticket.

The issue still persists in drupal 8.6.0-beta2.

The fatal error appears when a default value is given to a views filter and the view gets saved. The filter in my case is custom and extends the in_operator filter. It basically only adds other option values instead of the default Yes/No.

@lennartvv see #15, did you add a config schema for your custom filter?

So you need to have a config schema for all Views filter plugins, otherwise Drupal has no idea how to save your data to config (it defaults to a string value, but that is not what you are using, hence the fail).

See core/modules/views/config/schema/views.filter.schema.yml and core/modules/taxonomy/config/schema/taxonomy.views.schema.yml for some examples.

I was looking at that right after my post :-).

That solved the issue indeed. Though it was really trial and error as documentation is so low on this matter. Thanks for the quick response!

#15 contains the solution: all views filter plugins need config schema.

I had a problem with a view using the "Embed" display and the comment_ces_last_updated filter from Comment Statistics. Every time I tried to save my view:

InvalidArgumentException: The configuration property display.default.display_options.filters.last_updated.value.min doesn't exist. in Drupal\Core\Config\Schema\ArrayElement->get() (line 76 of core/lib/Drupal/Core/Config/Schema/ArrayElement.php). 

Patch #18 from https://www.drupal.org/project/drupal/issues/2925890 seemed to help.

@Kasey_MK that patch doesn't really fix the issue, it just changes it from an exception to a watchdog error. The underlying problem is most likely that Comment Statistics should have a config schema for the filter (didn't check).

I did find the config schema for the filter in comment.views.schema.yml:

views.filter.comment_ces_last_updated:
  type: views.filter.date
  label: 'Newer of last comment / node updated'

Which is what's used in my view as the plugin_id:

filters:
        last_updated:
          id: last_updated
          table: comment_entity_statistics
          field: last_updated
          relationship: none
          group_type: group
          admin_label: ''
          operator: '>='
          value:
            min: ''
            max: ''
            value: '-1 day'
            type: offset
          group: 1
          exposed: false
          expose:
            operator_id: ''
            label: ''
            description: ''
            use_operator: false
            operator: ''
            operator_limit_selection: false
            operator_list: {  }
            identifier: ''
            required: false
            remember: false
            multiple: false
            remember_roles:
              authenticated: authenticated
            placeholder: ''
            min_placeholder: ''
            max_placeholder: ''
          is_grouped: false
          group_info:
            label: ''
            description: ''
            identifier: ''
            optional: true
            widget: select
            multiple: false
            remember: false
            default_group: All
            default_group_multiple: {  }
            group_items: {  }
          plugin_id: comment_ces_last_updated

I got the same error "InvalidArgumentException: The configuration property display.page_search.display_options.filters.title.value.min doesn't exist." with 8.9.16.

I used one indexed filed to create an exposed filter, the indexed field is "fulltext", when I change it to "string", this error disappears.

I reinstall Views Autocomplete Filters module and it works again. Therefore, I am not sure if it is the problem of this module or the core.

#28 is a solution but if you want to search using 'contains' in your view filter then you need 'fulltext' and then you get the error (I managed to make it work on one field, but I don't know how anymore .. :-/ )

These two steps seem to have stabilized my site and I'm no longer seeing errors on saving my view nor on config-imports:

1. Apply the patch from https://www.drupal.org/project/drupal/issues/2925890 (I'm currently using #29)
2. Change the plugin_id for the troublesome filter in views.view.VIEWNAME.yml from comment_ces_last_updated to numeric

I think I have finally figured this one out (at least for the schema that was missing in my use case) - we need a schema for views.filter_value.comment_ces_last_updated
in core/modules/comment/config/schema/comment.views.schema.yml as follows:

views.filter_value.comment_ces_last_updated:
  type: views.filter_value.date
  label: 'Newer of last comment / node updated'

views.filter_value.date is of type views.filter_value.numeric which is defined in core/modules/views/config/schema/views.filter.schema.yml and which contains the missing min, max, and value schemas. Patch attached.

This problem definitely still exists in Drupal 9.5.x on a fresh install. Create some content and then try to create a view with a "Updated/commented date" filter set to something like "Is greater than or equal to" an offset value of something like "-10 minutes." The view can't be saved and yields the fatal error in this issue.

For other missing schemas, perhaps the issue is similar?

I have reproduced this problem per the steps to reproduce provided in #33.

As correctly noted in #32 there is already a ticket for handling the exception, so I'm setting the purpose of this ticket to be the provision of the missing schema entry.

I did try the patch in #33 and it worked well, thank you. Having made such a big change to the IS however, I don't think I can push this to RTBC.

Had a look and agree that #33 is an appropriate fix for this. I had a look if there were any other filters with type: views.filter.date in comment.views.schema.yml but this is the only one.

Moving this to comment.module rather than views.module since that's where the integration exists. Also moving to 10.1.x because I guess we need to fix it there first before a backport.

Finally, I think we should add some test coverage around this. There are some tests in the Drupal\Tests\comment\Kernel\Views namespace that might be worth looking at, for example CommentUserNameTest sounds like it might be testing similar functionality, or perhaps \Drupal\Tests\comment\Functional\Views\CommentFieldFilterTest.

I wonder if the test in #2086125: Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column would do the trick.