I have been experimenting with bootstrap-paragraphs 8.x-2.x-dev. I like what I see!

The attached pic shows an offset (padding) for an image paragraph with the setting wide. I am not sure about this one, but I would expect an image with the wide setting to be without an offset or padding, in other words the image should be aligned with the Nav Bar and the Title. Is my expectation wrong?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

platinum1 created an issue. See original summary.

thejimbirch’s picture

Something is wrong, the class name should not be visible in the display. Did you happen to go from the 1.x branch to 2.x branch?

platinum1’s picture

No. I did a new 8.4-dev installation, added bootstrap-paragraphs 2.x-dev via composer and ran composer update.

platinum1’s picture

In the project description I see:

"The fields in the 1.x branch all had the machine names field_. A few people ran into conflicts when installing this module on top of distributions. In 2.x we name spaced the fields, and Paragraph bundles to use bp_ instead."

I checked the field in my installation. I gave the field the name "Paragraph Body". The resulting field is called field_paragraph_body.

This clearly does not fit the above description - the field name starts with "field_" instead of "bp_". I checked the composer.json file and the terminal. Bootstrap-paragraphs 2.x-dev was specified in composer.json and the terminal installed:

- Installing drupal/bootstrap_paragraphs (dev-2.x 346c6ef): Cloning 346c6ef1f4

No error(s) shows up in dblog or the error_log file

platinum1’s picture

FileSize
56.34 KB

I have reinstalled the 8.4-dev site. The class name is no longer visible in the display.

The scaling to different image sizes is functional, but the image width "Full Screen" does not generate an image across 12 columns.
The padding, my original issue, is still visible. I don't think padding makes sense for an image. Alternatively, could there be an option which allows the choice between padding, so that the images aligns with text, and no padding so that the image aligns with the Nav Bar and Title?

thejimbirch’s picture

Do you have a url I could look at this?

platinum1’s picture

Yes. I tried it on two different sites:

http://www.raceboats.com/advanced-composite-powerboats

For testing this issue, I set up an additional site:

https://www.quitecontent.co.za/test

Let me know if you would like to access to this test site

thejimbirch’s picture

Category: Bug report » Feature request

  • thejimbirch committed 95672d5 on 8.x-2.x
    git commit -m 'Issue #2872991 by platinum1: Padding on image wide...
platinum1’s picture

Installed the new commit and cleared the cache.
Using the revised module, the "Full Screen" setting now aligns the image with the Nav Bar and Title. No more padding!

Aesthetically, I think this is a big improvement. Thank you @thejimbirch

platinum1’s picture

@thejimbirch Could you give me some feedback on my ideas of "Full Screen" vs. "Wide"?
I am currently using the "Full Screen" setting, and getting a result that I would define as "Wide", i.e. an image in 10 of 12 columns without padding. For me the setting "Full Screen" implies edge-to-edge in the browser, like in your site http://bp.jimbir.ch

Is my definition, and therefore expectation, wrong? Is the intention that an edge-to-edge image requires the Xeno Hero module on GitHub?

thejimbirch’s picture

@platinum1

Full Screen is col-sm-12 which goes all the way to the edge in your container.

I usually put the Paragraphs field in a region that has .container-fluid or make .container { width:100%; padding-left: 0; padding-right: 0; }

container

platinum1’s picture

Thank you for the input @thejimbirch. Much appreciated.

thejimbirch’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.