Hi there, and again thank you for the amazing module :)

I was wondering if we could adjust the following:

  protected function doLoadMultiple(array $ids = NULL) {
    $entities = array();
    foreach ($ids as $id) {
      if (strpos($id, '-')) {
        list($bundle, $external_id) = explode('-', $id, 2);

And change the explode to only split on the first '-' and keep the remaining as the external_id. I needed this when working with CKAN which stores an unique id like so:

"id": "1aa53c2b-62da-4982-9fa7-c198d27bb908",

So my full string would be "ckan-1aa53c2b-62da-4982-9fa7-c198d27bb908"

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sylus created an issue. See original summary.

sylus’s picture

Status: Active » Needs review
FileSize
1020 bytes
rlnorthcutt’s picture

I just stumbled across the same issue and came up with the same fix. +1 on this... its a huge blocker

rlnorthcutt’s picture

Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community
phenaproxima’s picture

Priority: Critical » Major

Generally, Critical priority is reserved for data loss and other five-alarm fires, but this doesn't seem like that kind of problem, although it is serious. Bumping the priority down a bit. :)

rp7’s picture

Title: Loosen doLoadMultiple for bundle + external_id extraction » Allow external ids with dashes (-)

Making the title a bit more clearer.

rp7’s picture

Rerolled against current DEV.

  • rp7 committed 6149777 on 8.x-1.x
    Issue #2872506 by sylus, rp7: Allow external ids with dashes (-)
    
rp7’s picture

Status: Reviewed & tested by the community » Fixed

Commited. Thank you for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.