Problem/Motivation

I have encountered the following exception after enabling the module on SimplyTest.me and attempting to create a new user.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "entity.user.recurly_signup" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 190 of /home/dc2md/www/core/lib/Drupal/Core/Routing/RouteProvider.php).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

markdorison’s picture

Priority: Normal » Major
markdorison’s picture

Status: Active » Needs review
FileSize
1.26 KB
markdorison’s picture

Status: Needs review » Needs work
markdorison’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
3.43 KB

Added test and additional check for whether plans are configured before redirecting. I am unsure why, but this is still failing.

Status: Needs review » Needs work

The last submitted patch, 5: routenotfoundexception-2872432-5.patch, failed testing.

markdorison’s picture

Status: Needs work » Needs review
FileSize
3.71 KB
397 bytes
adamzimmermann’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. I assume we want to prevent the redirect if the module is fully configured, but no plans have been entered into Recurly? That is how you have it now, just confirming.

Also, return count(recurly_subscription_plans($reset_cache)) > 0; could just be return !empty(recurly_subscription_plans($reset_cache));, but either way works.

colan’s picture

Status: Reviewed & tested by the community » Needs work

I think !empty() is more readable.

markdorison’s picture

Status: Needs work » Needs review
FileSize
3.71 KB
472 bytes
adamzimmermann’s picture

Status: Needs review » Reviewed & tested by the community
adamzimmermann’s picture

  • markdorison committed b96f430 on 8.x-1.x
    Issue #2872432 by markdorison, adamzimmermann: RouteNotFoundException:...
markdorison’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.