Include project namespace for module dependencies [#2872115]

This task is for a new student in MD Systems, don't do it if it was not assigned to you.

Problem/Motivation

Similar to the #2801043: Include project namespace for module dependencies
Module names are not unique so using just module names for dependencies may get the wrong project.
See [#2299747] for more information.

Proposed resolution

Change the namespaces of the module dependencies.
No need for a module to be in both test dependency and regular.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#8	include_namespaces-2872115-8.patch	1.34 KB	Ginovski
#8	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 75 pass
#8	interdiff-2872115-4-8.txt	309 bytes	Ginovski
#4	include_namespaces-2872115-4.patch	1.34 KB	basti.diaaz
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 75 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 April 2017 at 11:37

Ginovski created an issue. See original summary.

Comment #2

basti.diaaz CreditAttribution: basti.diaaz as a volunteer commented 3 May 2017 at 07:25

Comment #3

basti.diaaz CreditAttribution: basti.diaaz as a volunteer commented 3 May 2017 at 07:28

Assigned:

Unassigned

» basti.diaaz

Comment #4

basti.diaaz CreditAttribution: basti.diaaz as a volunteer commented 3 May 2017 at 07:53

File	Size
include_namespaces-2872115-4.patch	1.34 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 75 pass

Comment #5

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented 3 May 2017 at 08:03

Status:

Active

» Needs review

Comment #6

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented 5 May 2017 at 09:26

Status:

Needs review

» Reviewed & tested by the community

Comment #7

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 8 May 2017 at 15:46

Status:

Reviewed & tested by the community

» Needs work

+++ b/simplenews.info.yml
@@ -4,10 +4,9 @@ type: module
 dependencies:
-  - node
-  - field
-  - options
-  - views
-test_dependencies:
-  - monitoring
+  - drupal:node
+  - drupal:field
+  - drupal:options
+  - drupal:views
+  - monitoring:monitoring
 configure: simplenews.newsletter_list

monitoring was only a test dependency now it is a normal dependency, that's not correct, it needs to remain in the separate list.