Hey !

When I updated drupal to the version 8.3.1, I also updated display suite. The update failed because of this module, I had to uninstall it, do the update, and reinstall it at the end.

It seems that the need of the CSS rebuild when the cache is cleared make the update crash.

CommentFileSizeAuthor
#3 simple_menu_icons-change_hook_not_rebuild_on_update-2871491-3.patch428 bytessylvainar
bug.txt1.48 KBsylvainar

Comments

sylvainar created an issue. See original summary.

sylvainar’s picture

sylvainar commented

It seems that it's not the good hook.

According to Drupal.org drupal API, the cache flush hook shouldn't be used to flush custom cache.

The hook_rebuild should be used instead.

I'm working on a patch, I'll keep you informed.

sylvainar’s picture

sylvainar commented
StatusFileSize
new simple_menu_icons-change_hook_not_rebuild_on_update-2871491-3.patch428 bytes

Yup, changing the hook was the solution. I retried all the update procedure and it doesn't fail anymore, and the module is still working properly.

sylvainar’s picture

sylvainar commented
Status: Active » Needs review
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs review » Fixed

https://www.drupal.org/project/simple_menu_icons/issues/2880544#comment-...

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Fixed » Closed (fixed)