LDAP Authentication: Email update settings ignored [#2871293]

Hi,

On Authentication tab setting, if you set email update to :

Update stored email if LDAP email differs at login and notify user.

And DO NOT check

Ignore the Email Update settings and never update the stored email if the template is used.

In the LoginValidator class, this option is evaluate to true (!false). Here is a patch to fix this.

Regards.

Comment	File	Size	Author
#2	ldap-authentication_email_update_setting_ignored-2871293-1.patch	590 bytes	mogtofu33
#2	8.x-3.x: PHP 5.6 & MySQL 5.5, D8.4 28 pass PHP 7 & MySQL 5.5, D8.4 28 pass PHP 7 & PostgreSQL 9.1, D8.4 28 pass PHP 7 & SQLite 3.14, D8.4 28 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 April 2017 at 04:31

mogtofu33 created an issue. See original summary.

Comment #2

mogtofu33 CreditAttribution: mogtofu33 at Catalyst IT commented 20 April 2017 at 04:32

File	Size
ldap-authentication_email_update_setting_ignored-2871293-1.patch	590 bytes
8.x-3.x: PHP 5.6 & MySQL 5.5, D8.4 28 pass PHP 7 & MySQL 5.5, D8.4 28 pass PHP 7 & PostgreSQL 9.1, D8.4 28 pass PHP 7 & SQLite 3.14, D8.4 28 pass

Comment #3

1 May 2017 at 20:27

grahl committed 806e117 on 8.x-3.x authored by mogtofu33

Issue #2871293 by mogtofu33: LDAP Authentication: Email update settings...

Comment #4

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 1 May 2017 at 20:28

Status:

Needs review

» Fixed

Hi mogtofu33

Thanks for your patch!

I'm committing this as-is since it's clearly the intended behavior. Looking over that section it's clear to me that the convoluted logic between "email update" and "email template" is not ideal but I don't see an easy and quick way to patch that. Might just need to cover that with unit tests...patches welcome.