Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajabNatshah created an issue. See original summary.

Rajab Natshah’s picture

Title: [8.4.x][Vartheme Admin] Optimization round no. 2 for varbase admin theme » [Vartheme Admin] Optimization round no. 2 for varbase admin theme
mostafadev’s picture

FileSize
202.08 KB
Rajab Natshah’s picture

Issue summary: View changes

Please add other patches to the right project:

Adminimal Admin Toolbar (Drupal 8) Issues CSS fixes in RTL
#2871009: CSS fixes in RTL

Admin Toolbar Issues CSS fixes in RTL
#2871028: CSS fixes in RTL

mostafadev’s picture

FileSize
3.53 KB
Rajab Natshah’s picture

Good progress :)

Are you committing all changes locally?

please do not
To do the patch to work with the latest work on 8.x-4.x branch
you will need to git pull the latest changes. up to the point of latest code had been committed to drupal.org.
Patch files will not include changes for other patches!!

Have you tested the composer?

Copy Varbase code to the testing folder
Go to into the test folder
When you run: /var/www/html/test/varbase$ composer install
Then you should not have any errors

Make sure that the JSON format is right, and the format is following the composer.json format.
We need to add a coma

       "drupal/coffee": {
         "Issue #2815381 by mqanneh, ahmadhalah, michaelmol: Coffee breaks whole page when using right to left (rtl) languages in drupal 8":
         "https://www.drupal.org/files/issues/coffee-coffee_breaks_page_with_rtl-2815381-6.patch"
+        "Fixed Coffee in RTL and any other page that has a visible bug By Mostafa":
+        "https://www.drupal.org/files/issues/2872093_1.patch"
       },

About naming the path.
your next patch file could be named 2871079-5.patch
The format is
git diff > [description]-[issue-number]-[comment-number].patch

Rajab Natshah’s picture

mostafadev’s picture

FileSize
933 bytes
Rajab Natshah’s picture

You will need to git pull the latest changes. up to the point of latest code had been committed to drupal.org.
Then create the patch for your changes.

mostafadev’s picture

FileSize
203.83 KB
Rajab Natshah’s picture

  1. Links for patchs are old, they are not for the latest patch files.
  2. Some Drupal standard coding. you do have space after "4.0-alpha2" in the patch
  3. Please have one new line at the end of all files. do not remove it when you do the patch, or you will get "\ No newline at end of file"
-    "drupal/varbase_carousels": "4.0-alpha2"
-  }
+    "drupal/varbase_carousels": "4.0-alpha2" 
+ }
 }
mostafadev’s picture

FileSize
2.72 KB
mostafadev’s picture

FileSize
1.43 KB
mostafadev’s picture

Rajab Natshah’s picture

Status: Needs work » Needs review
Rajab Natshah’s picture

Status: Needs review » Needs work
mostafadev’s picture

FileSize
4.48 KB
mostafadev’s picture

FileSize
4.03 KB
mostafadev’s picture

FileSize
4.03 KB
mostafadev’s picture

FileSize
4.25 KB
mostafadev’s picture

FileSize
4.03 KB
Rajab Natshah’s picture

Assigned: Unassigned » Rajab Natshah
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

FileSize
11.14 KB
Rajab Natshah’s picture

  • RajabNatshah committed d88cfb2 on 8.x-4.x
    Issue #2871079 by mostafadev, RajabNatshah: [Vartheme Admin]...
Rajab Natshah’s picture

Assigned: Rajab Natshah » Mohammed J. Razem
Status: Needs work » Needs review
Rajab Natshah’s picture

Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Status: Fixed » Closed (fixed)