Hi

I've noticed that the sites created with a GIT repository are not showing their credentials (which branch is used and repository url).
On testing this out, I've noticed that a new site with GIT data saves fine the first time I create the site, but when updating the site, my GIT data is lost.

Next I've checked my database to see if the data is present or not, but here it's gone as well.
I think that the function hosting_git_node_update($node) is wrong. On var_dumping the $node in that function, I can see the GIT data. But on var_dumping the $node->git object, I cannot see the correct data.

Can someone confirm this?
With this bug we can not use this module because we can't edit our sites after creating them!

Comments

yerlix created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Personally, I don't recommend creating sites with Git (but I'll admit I don't really understand how it's implemented). What I do instead is:

  1. Create a new platform using a Git repository.
  2. Create a new site on it (leaving the Git fields blank).
  3. To update the site, create another platform using a Git repository.
  4. Migrate the site to the new platform.

Instead of creating a new platform with the latest code, you could also run a Git pull task, but I wouldn't do that on Staging or Production (just Dev) because it doesn't take advantage of Aegir's rollback functionality built into site migrations.

I believe this is a safer workflow.

Would this help your use case?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Priority: Critical » Major

Downgrading to Major as this module still works with different use cases.

yerlix’s picture

yerlix CreditAttribution: yerlix commented

Hi Colan

So you mean to create a new platform every time you update the website?
That is not an option for our client because we manage around 30 sites in Aegir. And the client can make small code changes in css so they want to update the sites as well.
Every site can be having updates daily, so it's not an easy workflow to create a new platform daily and migrate 30 sites just for a small css change.

That's why we want to use the Git pull task. The disadvantage of Aegir's rollback functionality is not useful for us in this case, because for some sites, we need to update multiple Git repositories so a rollback for one repository does not necessarily rollback everything.
It's a complex structure I know.

Thanks for your feedback and your insights in this matter, but for us and our client this is not a workflow we can adopt. We need the Git pull task for updating a single site on a daily basis.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented
Status: Active » Needs review

I also use this workflow on several sites so it should 'just work'.

On the 3.10 version I can reproduce it. :(

I tried to reproduce this while testing #2838489: Support drupal being in a subdirectory of a git repo but it seems to be fixed by the work there.

Could you try the 2838489-repo-platform-path feature branch for hosting_git?

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented

It might also useful to review #2544906: Pickup git setting from disk ... which could help to restore things.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented
Status: Needs review » Fixed

This should be fixed now that #2838489: Support drupal being in a subdirectory of a git repo is committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yerlix’s picture

yerlix CreditAttribution: yerlix commented

I've just updated to version 3.10 (which has your linked issue merged) but the behavior is still the same.
Create site with a git url, save it -> all good, edit and save it again -> git url is gone

Can this issue be reopened, I'll try and squeeze in some private time to fix this issue.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented

@yerlix That was merged after the 3.10 release, so you'd have to run a dev release or wait for 3.11 to get it. Feel free to re-open if you still have an problem after updating.

yerlix’s picture

yerlix CreditAttribution: yerlix commented

@helmo

Thanks for your feedback, I've just updated to the dev version (7.x-3.10+34-dev) but I see the same behavior.
I would love to reopen this, so I can take a look at a possible fix, but only maintainers can reopen this issue.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented
Status: Closed (fixed) » Active

Ah, yes the limited re-open option is a fairly recent change on D.o.

Please let me know what you find...

yerlix’s picture

yerlix CreditAttribution: yerlix commented
Status: Active » Fixed

@helmo a day after you've reopened this issue, the next version was released. That one did solve my problem. Why the dev version did not is still a mystery to me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.