Paragraphs Type icons are temporary files

1. +++ b/src/Entity/ParagraphsType.php
   @@ -84,14 +86,9 @@ class ParagraphsType extends ConfigEntityBundleBase implements ParagraphsTypeInt
   +    $icon_uuid = $this->icon_uuid;
   +    if ($icon_uuid && $icon = $this->getFileByUuid($icon_uuid)) {
   

   No need for new variable here, just use $this->icon_uuid

2. +++ b/src/Tests/Classic/ParagraphsTypesTest.php
   @@ -60,6 +72,12 @@ class ParagraphsTypesTest extends ParagraphsTestBase {
   +    $this->drupalGet('admin/content/files');
   +    $this->assertLink('image-test.png');
   +    $this->clickLink('1 place');
   

   You could add an assertion for the permanent status here.

3. +++ b/src/Entity/ParagraphsType.php
   @@ -167,4 +164,56 @@ class ParagraphsType extends ConfigEntityBundleBase implements ParagraphsTypeInt
   +      $new_icon_uuid = $this->icon_uuid;
   

   Same for this, no need for this new variable, it is only used once.

4. +++ b/src/Entity/ParagraphsType.php
   @@ -167,4 +164,56 @@ class ParagraphsType extends ConfigEntityBundleBase implements ParagraphsTypeInt
   +      if ($update) {
   

   This should be moved outside, it is nested in the opposite if statement(!update).
   Or better, you can remove it and just leave the delete usage of the old icon inside the opposite if statement(!update).

5. +++ b/src/Entity/ParagraphsType.php
   @@ -167,4 +164,56 @@ class ParagraphsType extends ConfigEntityBundleBase implements ParagraphsTypeInt
   +        $old_icon_uuid = $this->original->icon_uuid;
   +        if ($old_icon_uuid && $old_icon = $this->getFileByUuid($old_icon_uuid)) {
   

   After you make the previous change, you will have to check if isset($this->original) here. Because when creating a new paragraph type, there is no original and this displays warning message.

RTBC +1

+++ b/src/Entity/ParagraphsType.php
@@ -167,4 +163,53 @@ class ParagraphsType extends ConfigEntityBundleBase implements ParagraphsTypeInt
+   * @return \Drupal\file_entity\FileEntityInterface|null
+   *  The file entity. NULL if the UUID is invalid.
+   */
+  protected function getFileByUuid($uuid) {
+    if ($uuid) {

file_entity is an optional contrib module. We don't want to type hint on that but FileInterface in core. Also, as discussed, $uuid shouldn't be allowed to be NULL and should never becalled as NULL in the patch. Update the type and remove the if () check.

$files_array is a bit uncommon, usually we just use $files or so, but fine.

It seems that this needs a re-roll :/

Committed, thanks.