Extend the entity reference views filter with the ability to sort the referenced options based on the selected bundle field.

Requested feature: Generalize TaxonomyIndexTid filter to be available for all entity reference fields (2429699) #65

CommentFileSizeAuthor
#15 views2.png38 KBsanjayk
#15 views1.png90.72 KBsanjayk
#4 interdiff-2870766-2-4.txt1.09 KBakozma
#4 entity_reference_view_filter_sort_options-2870766-4.patch4.58 KBakozma
#2 entity_reference_view_filter_sort_options-2870766-2.patch5.5 KBakozma
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akozma created an issue. See original summary.

akozma’s picture

akozma CreditAttribution: akozma commented
FileSize
entity_reference_view_filter_sort_options-2870766-2.patch5.5 KB

The patch allows to order the filter values based on the selected bundle field.

However there's an issue as the already sorted results are grouped by bundle in the selection plugin callback
See \Drupal\Core\Entity\Plugin\EntityReferenceSelection\DefaultSelection::getReferenceableEntities()

    foreach ($entities as $entity_id => $entity) {
      $bundle = $entity->bundle();
      $options[$bundle][$entity_id] = Html::escape($this->entityManager->getTranslationFromContext($entity)->label());
    }

    return $options;
akozma’s picture

akozma CreditAttribution: akozma commented
Assigned: akozma » Unassigned
Status: Active » Needs work
akozma’s picture

akozma CreditAttribution: akozma commented
FileSize
entity_reference_view_filter_sort_options-2870766-4.patch4.58 KB
interdiff-2870766-2-4.txt1.09 KB

Fixes the coding standard, indentation.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Needs work » Needs review

The last submitted patch, 2: entity_reference_view_filter_sort_options-2870766-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: entity_reference_view_filter_sort_options-2870766-4.patch, failed testing.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
CreditAttribution: jonathanshaw commented
Component: entity_reference.module » views.module
Category: Task » Feature request
Priority: Major » Normal
sanjayk’s picture

sanjayk CreditAttribution: sanjayk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
views1.png90.72 KB
views2.png38 KB

In order to recreate i have used basic page and article content type for which had added a reference field from Basic content type into Article content type.

Added three nodes for Article and two for Basic page.

Basic page nodes: node/1, node/4
Article nodes: node/2, node/3, node/5

Following Basic page nodes are referenced in Article nodes
node/2 => node/1
node/3 => node/1
node/5 => node/4

based on these content I had configured a view to recreate the scenario, I find this to be working as expected. Attaching screenshot of the view and its settings for reference.

sanjayk’s picture

sanjayk CreditAttribution: sanjayk as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
CreditAttribution: jonathanshaw commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs work for reroll and #2

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

manishsaharan’s picture

manishsaharan CreditAttribution: manishsaharan at Specbee commented
Status: Needs work » Active

#2 can't be re-rolled since there is no such file views/src/Plugin/views/filter/EntityReference.php present in d10.