Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Due to their overall effort in the PHPUnit initiative I asked Lendude and michielnugter whether they want to lead the initiative together with me.
Lendude made the suggestion to use the provisional initiative leads for that, so they can both see whether they are comfortable with the new position, for example in terms of workload.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#30 | 2870513-30.patch | 508 bytes | alexpott |
#21 | 2870513-21.patch | 630 bytes | michielnugter |
Comments
Comment #2
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedIt's an honor for me to be asked!
I've been working a lot on the PHPUnit initiative and have come to really care a lot about it.
For the last 7 years I have worked with (and loved) Drupal almost each day. I started with Drupal 5 and have seen the massive steps Drupal has made over the last few years. I have worked on several large and complex websites and always have had a focus on quality.
I got into the Drupal community itself since Drupal 8, only fairly recent. I started with some minor issues (conversions of BrowserTestBase to JavascriptTestBase) and quickly worked my way up to working on changes to the core testing framework. I worked on several random failures and did a lot of research into the proper usage of the JavascriptTestBase tests.
I really care about the initiative because I see a huge value in the move from Simpletest to PHPUnit. I also see that it lacks a bit of sexyness and general interest, that's one of the reasons I got into it.
I'm not sure if many things will change for me once I'm lead, in a good way :) I have been involved in the more advanced tasks in the initiative and have started to focus more on the planning and general management of the issue queue. To me that's what beeing a lead is: keeping the initiative on the right track and making sure the right things get done at the right time.
Is short: I really look forward to this and I will certainly try my very best for the initiative!
Comment #3
dmsmidtI've seen miechielnugter and Lendude work together seamlessly. They are enthusiastic about the initiative and know their way around testing. They also have proven themselves by making Views better and better all the time.
You guys have my endorsement!
Comment #4
LendudeI would be happy to step in. Like @michielnugter I believe the PHPUnit Initiative is a great move forward and would be happy to keep spending my time on it with a little shift in focus.
I think at DevDays Seville we showed that we can help the Initiative by mentoring and getting people enthusiastic about helping out.
Comment #5
finne++
I think the PHPUnit Initiative would be in great hands with michielnugter and Lendude.
Comment #6
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedPatch for MAINTAINERS.txt. Added us to the PHPUnit initiative and the provisional membership as proposed by LenDude.
Comment #7
dawehnerIsn't that sorted normally alphabetically?
Comment #8
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedWell, that's what I was thinking as well, but looking at the rest it doesn't seem like it. I assumed sort by Drupal-seniority :)
Comment #9
dagmarAlthough is almost clear form #2, to make this formal we need confirmation from @michielnugter that he has read and would like to take on the responsibilities outlined in https://www.drupal.org/contribute/core/maintainers and particularly https://www.drupal.org/contribute/core/maintainers#initiative
Comment #10
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedThank you for pointing me to the article, it has made the lead role a lot clearer.
I have just read the article and I understand and accept the described responsibilities. I'm really looking forward to assuming the role (which I'm already moving toward) and working on making the PHPUnit initiative a succes!
Comment #11
dagmarI been following @michielnugter progress during this week and his job really adds a lot of value to the phpunit initiative. It seems there's consensus from other community members here too.
Comment #12
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commented@dagmar: Thanks for the kind words!
I'll be sure to continue doing my best to make the PHPUnit initiative a succes.
Comment #13
alexpottWith initiative lead changes we need a +1 from Dries.
Comment #14
Dries CreditAttribution: Dries commentedI'm comfortable with this patch being committed. Thanks for stepping up to help Len and Michiel!
Comment #15
xjmThanks Dries! I'm really glad to see us adding provisional initiative leads. :)
One small concern is that I don't think this is formatted clearly. I don't think the names should be listed twice. When applied, the patch looks like this:
This makes it look like Lendude and michielnutger are both full initiative leads for PHPUnit, and provisional initiative leads for Media.
For core committers (the only other section with provisional members), the formatting is a bit different already:
It's not quite the same since product, framework, and release management are roles rather than a particular part of core, so it's not a great model for initiatives.
Maybe the provisional membership could be indented under the initiative, like we have for the DB subsystem?
Comment #16
xjm(Come to think of it, the committer section as currently formatted is also getting hard to read as we add new members and grow the team but that's out of scope here.) :)
Comment #17
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedThank you @Dries for your confidence in us!
@xjm:
Did you mean something like this? I does make it a lot clearer like this. Though I love the API-first Initiative I have my plate full with the PHPUnit initiative right now :)
Comment #18
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #19
xjmYep, I think that looks good. Thanks @michielnugter!
Comment #21
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedHope I'll have better luck with the actual work :)
Rerolled the patch after #2874043: Node module should have a listed maintainer.
Comment #22
xjm#21 should not have required a reroll? It's in a totally different part of the file. Weird...
Comment #23
Gábor HojtsyI wanted to commit this given signoff by @Dries and @xjm. Went ahead and granted issue maintainership role on the Drupal project to Lendude and michielnugter. However as per https://www.drupal.org/core/maintainers/provisional-committers I should not commit MAINTAINERS.txt changes as a provisional core committer, so I guess I cannot complete this.
Comment #26
catchCommitted/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!
Comment #27
Wim LeersThis was added to the
API-first Initiative
section instead of thePHPUnit Initiative
section.#17 was correct, but the rebase in #21 moved it to the wrong location.
Comment #30
alexpottHere's a patch with the additions in the right place.
Git doesn't do so well with this file because of all the repetition.
Comment #31
xjmLol. That's kinda my bad for RTBCing it.
Comment #32
alexpottCommitted and pushed 1fbc766 to 8.4.x and 5960157 to 8.3.x. Thanks!
Comment #35
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedWow, sorry about that and thanks for fixing it!
Comment #36
Wim LeersYep, this is mostly on git, for not using enough context :)