Problem

Webform module currently requires a dozen external libraries which provide important UI enhancements. Front-end developers should be able to disable any external library dependency and utilize a contrib or custom enhancement.

Solution

Better document external dependencies and allow webform admins to exclude libraries.

Goals

  • Make it possible to disable iCheck integration.
  • Make it possible to disable Select2 integration.
  • Make it possible to enabled Chosen integration with or without the chosen.module
  • Generate Webform.libraires.make.yml and composer.json

Tasks

  • Make sure external library names are completely insync.
  • Add link to examples for all libraries.
  • Move webform.libraries.make.yml info into WebformLibraryManager.
  • WebformLibraryManager::attached($build, $library, $require); TRUE|FALSE
  • WebformLibraryManager::isEnabled($library);
  • WebformLibraryManager::isDisabled($library);
  • Add 'Excluded Libraries' to admin settings.
  • Update drush webform-libraries to only download supported codebases
  • Update \Drupal\webform\WebformElementBase::isEnabled to also check libraries
  • Add libraries to WebformElement plugin definition
  • Display libraries on 'Select available element types' and elements list page.
  • Improve drush webform-libraries commands.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

  • jrockowitz committed bf37e68 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management.
    

  • jrockowitz committed 374195d on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management.
    

  • jrockowitz committed 38a6b94 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management.
    

  • jrockowitz committed 9a5b55a on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management. Setup excluded...

  • jrockowitz committed a4426d0 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management
    

  • jrockowitz committed ee3adc3 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management
    

  • jrockowitz committed 00ba990 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management. Write tests.
    
jrockowitz’s picture

Status: Active » Needs review
FileSize
91.7 KB

Status: Needs review » Needs work

The last submitted patch, 9: improve_external-2870218-8.patch, failed testing.

  • jrockowitz committed 5122206 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management. Removing require...
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
91.41 KB

  • jrockowitz committed cae70c3 on 2870218-improve-library-management
    Issue #2870218: Improve External Library Management. Fix tests.
    

Status: Needs review » Needs work

The last submitted patch, 12: improve_external-2870218-12.patch, failed testing.

jrockowitz’s picture

Status: Needs work » Needs review
FileSize
82.85 KB

  • jrockowitz committed 2a5507f on 8.x-5.x
    Issue #2870218 by jrockowitz: Improve External Library Management
    
jrockowitz’s picture

Status: Needs review » Fixed
jrockowitz’s picture

Status: Fixed » Active

  • jrockowitz committed 2a5507f on 2870218-improve-library-management-v2
    Issue #2870218 by jrockowitz: Improve External Library Management
    

  • jrockowitz committed d8e826d on 2870218-improve-library-management-v2
    Issue #2870218: Improve External Library Management
    

  • jrockowitz committed 6c2c35a on 2870218-improve-library-management-v2
    Issue #2870218: Improve External Library Management.
    
jrockowitz’s picture

Status: Active » Needs review
FileSize
23.6 KB

  • jrockowitz committed 57c3d10 on 8.x-5.x
    Issue #2870218 by jrockowitz: Improve External Library Management
    
jrockowitz’s picture

Status: Needs review » Fixed

  • jrockowitz committed 115bd92 on 8.x-5.x
    Issue #2870218: Improve External Library Management. Update...

  • jrockowitz committed 508e32d on 8.x-5.x
    Issue #2870218: Improve External Library Management.
    

  • jrockowitz committed 8104cf9 on 8.x-5.x
    Issue #2870218 by jrockowitz: Improve External Library Management
    

  • jrockowitz committed 3318773 on 8.x-5.x
    Issue #2870218 by jrockowitz: Improve External Library Management. Fix...

  • jrockowitz committed 74b297e on 8.x-5.x
    Issue #2870218 by jrockowitz: Improve External Library Management. Minor...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.