Nice!

A few points from my first test run:

  • There's a 7.x-1.x branch and 7.x-3.x(behind) ... for consistency with the rest of the eco system ... default branch 7.x-3.x on D.o? done
  • The project node page on D.o does not link to the aegirproject.org site
  • On the project node: basic usage: step 1. It says to ignore the "upgrade target" field ... what should the 'type' field be?
  • The 'update signature' field is locked... could do with a description.... and/or hide on node creation. done
  • Webserver field ... when there's only one ... select it? done
  • A 'No results behaviour' would be nice for the view on the distribution node page. "This distribution has no platforms yet." done
  • Why not 'trigger build' by default on Stock distro creation? I first ended up running 'drush @hm hosting-distribution_stock_update' by hand as my docker dev container was not running queues. done

Comments

helmo created an issue. See original summary.

ergonlogic’s picture

There's a 7.x-1.x branch and 7.x-3.x(behind) ... for consistency with the rest of the eco system ... default branch 7.x-3.x on D.o?

I'd only originally created the 3.x branch because d.o wouldn't let me move an issue without a matching branch. I'm ok with shifting to 3.x, though it seems silly for a project still in beta to be on version 3 :p

The project node page on D.o does not link to the aegirproject.org site
On the project node: basic usage: step 1. It says to ignore the "upgrade target" field ... what should the 'type' field be?

That was a first stab at documentation when the base module was originally prototyped. It all needs a significant cleanup.

The 'update signature' field is locked... could do with a description.... and/or hide on node creation.

It's really only used internally, so could probably be hidden everywhere.

Webserver field ... when there's only one ... select it?

Good idea.

A 'No results behaviour' would be nice for the view on the distribution node page. "This distribution has no platforms yet."

Yep.

Why not 'trigger build' by default on Stock distro creation? I first ended up running 'drush @hm hosting-distribution_stock_update' by hand as my docker dev container was not running queues.

See: #2868639: Trigger build by default for new distros.

ergonlogic’s picture

Issue summary: View changes

  • ergonlogic committed 9336d67 on 7.x-3.x
    Issue #2869389: Default webserver to first available.
    
  • ergonlogic committed c358265 on 7.x-3.x
    Issue #2869389: Hide signature field.
    
  • ergonlogic committed cfd3640 on 7.x-3.x
    Issue #2869389: Provide no-results message when there are no platforms...
ergonlogic’s picture

Issue summary: View changes
ergonlogic’s picture

Status: Active » Needs review

I added #2869867: Clean up project page and docs to follow-up on the remaining issues.

Setting as 'needs review' unless I missed anything. I'll push a new release later today with these fixes. THanks again, @helmo, for the initial review!

ergonlogic’s picture

Version: 7.x-1.x-dev » 7.x-3.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

helmo’s picture