EntityManager has been split into 11 classes (more info). So now EntityManager and EntityManagerInterface are deprecated.

CommentFileSizeAuthor
#14 2869271-14.patch1.6 KBberdir
#11 2869271-11-Replace-all-usages-of-deprecated-EntityManagerInterface.revert.patch1.57 KBsanduhrs
#5 interdiff.txt543 bytesPavan B S
#5 2869271-5.patch1.57 KBPavan B S
#2 2869271-2.patch1.53 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new 2869271-2.patch1.53 KB

Applying the patch, please review.

laravz’s picture

laravz commented
Status: Needs review » Needs work

Hi,

Although the patch was applied successfully I found a minor error in the type hinting. The parameter name in the php doc block has not been changed to $entity_type_manager, while the parameter itself has.

@param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_manager

should become

@param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
Pavan B S’s picture

Pavan B S commented

@laravz, thanks for the input , I will be working on it.

Pavan B S’s picture

Pavan B S commented
StatusFileSize
new 2869271-5.patch1.57 KB
new interdiff.txt543 bytes

Reapplying the patch, please review.

Pavan B S’s picture

Pavan B S commented
Status: Needs work » Needs review
laravz’s picture

laravz commented
Status: Needs review » Reviewed & tested by the community

The patch was applied successfully to both the dev branch and my project branch. Doc block parameter name is now OK, no further issues were found.

dhruveshdtripathi’s picture

dhruveshdtripathi commented

Thanks @Pavan B S and @LaravZ for patch and review

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Related issues: +#2906160: Fatal error due to core still using EntityManagerInterface
StatusFileSize
new 2869271-11-Replace-all-usages-of-deprecated-EntityManagerInterface.revert.patch1.57 KB

Attached is a patch to revert this commit for the time being.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Closed (fixed) » Postponed

Committed the revert, this is postponed on core (aka me, I suppose) figuring out what to do about that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new 2869271-14.patch1.6 KB

Here's a new patch that uses the new pattern to call parent::static() and then assign the property, this avoids having to pas the correct service to the parent, which now actually is a entity repository, not entity type manager.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

  • Berdir committed c8c7b5d on 8.x-1.x 
    Issue #2869271 by Pavan B S, Berdir, sanduhrs, dhruveshdtripathi, LaravZ...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.