Validation fails when changing the domain machine name [#2869197]

When you edit an existing domain record and change its machine name, the validation fails saying that the hostname already exists.

Steps to reproduce:

- Create a domain record
- Try to edit the domain record and change its machine name
- You are unable to save the domain record

A workaround is editing the domain record changing its hostname temporarily to something else at the same time you change the machine name then editing again to change back the hostname to its original value.

Comment	File	Size	Author
#4	2869197-domain-machine_name.patch	2.29 KB	agentrickard

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 April 2017 at 20:26

recidive created an issue. See original summary.

Comment #2

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 15 April 2017 at 15:02

A statement of the exact error message would be helpful, otherwise, this is a great report.

Comment #3

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 15 April 2017 at 15:08

Here is the problem code:

    // Validate if the same hostname exists.
    // Do not use domain loader because it may change hostname.
    $existing = $this->storage->loadByProperties(['hostname' => $hostname]);
    $existing = reset($existing);
    if ($existing && $existing->id() != $entity->id()) {
      $form_state->setErrorByName('hostname', $this->t('The hostname is already registered.'));
    }

I think we can get around this by checking the domain_id() value, which is not editable.

    if ($existing && $existing->getDomainId() != $entity->getDomainId()) {
      $form_state->setErrorByName('hostname', $this->t('The hostname is already registered.'));
    }

I'll roll a patch in a minute.