Support from Acquia helps fund testing for Drupal Acquia logo

Comments

B@zel created an issue. See original summary.

vasyl.kletsko’s picture

vasyl.kletsko’s picture

Issue summary: View changes
vasyl.kletsko’s picture

Also, I created the patch that adds success message after a group was deleted.

riddhi.addweb’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
31.08 KB
32.27 KB

Thanks B@zel for patch, I have applied your patch which is mention in #5 using simplytest.me and issue regarding success message for update group has been fixed. PFA Screenshots.

kristiaanvandeneynde’s picture

Looks good, except for the %operation bit. This would make those verbs untranslatable. Will combine the patches and clean them up.

kristiaanvandeneynde’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
1.85 KB

Please try this for creation, updating and deletion.

vasyl.kletsko’s picture

FileSize
51.53 KB
42.43 KB
30.21 KB

I tested all those actions, works good.

vasyl.kletsko’s picture

Status: Needs review » Reviewed & tested by the community

kristiaanvandeneynde’s picture

Status: Reviewed & tested by the community » Fixed

Great, thanks all!

vasyl.kletsko’s picture

I improved your code by removing repeated calling of the "t()" method.

vasyl.kletsko’s picture

Status: Fixed » Needs review
kristiaanvandeneynde’s picture

Status: Needs review » Fixed

You can't do that because then the translation parser for LDO doesn't pick up the strings. All t() calls should have a literal string in them instead of a variable.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.