I've discovered that on some sites that I'm testing Nice Menus on, there's some broken menu functionality and a `ReferenceError: Drupal is not defined` error on the console.

This is because nice_menus.libraries.yml does not list core/drupal as a dependency for nice_menus.js. If you have other components on the page that do have that dependency, you won't encounter the problem.

CommentFileSizeAuthor
#2 nice_menus-js_dependency-2867879-2.patch325 byteshart0554
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hart0554 created an issue. See original summary.

hart0554’s picture

Patch attached.

  • xiukun.zhou committed f3af513 on 8.x-1.x authored by hart0554
    Issue #2867879 by hart0554: Javascript throws error on some installs
    
xiukun.zhou’s picture

Thanks hart0554

xiukun.zhou’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.