Add new fulltext fields to enabled fields processors

Thanks for looking into this issue. I was mired by it for a little while today.

How about adding a "select all fields" checkbox on a processor config, with a description below the checkbox saying "by selecting all, any new fields added to the index which are eligible for this processor will be automatically included in this processor." Choosing "select all fields" disables the checkboxes on each field, if that's conveniently possible. This simplifies a tiny bit the logic for checking whether a new field should be added to the processor automatically, since this will be done only if "select all" is chosen. It also gives site admins the ability to explicitly control this behaviour, and things will work the way they expect it to, one way or the other.

Hello,
Patch in #3 worked for me.

1. Go to Fields tab: Added field body as fulltext
2. Go to Processors tab: Checked HTML Filter and the option "Enable on all supported fields"
3. Go to Fields tab, and added body_1 (again)
4. Go to Processors tab. The option "Enable on all supported fields" is checked and if I unchecked it, it will show that the processor is running on all fields, including the new one
5. I runned the "Index now" and checked the index. Both body fields shows in Solr document properly filtered when enabled

"ts_body":"<p>PEtererasdascas <strong>asiodfuh</strong> aoispjf a</p>\n",
        "terms_ts_body":"<p>PEtererasdascas <strong>asiodfuh</strong> aoispjf a</p>\n",
        "its_uid":1,
        "itm_field_user_likes":[39,
          41],
        "its_field_user_likes":39,
        "ts_body_1":"<p>PEtererasdascas <strong>asiodfuh</strong> aoispjf a</p>\n",
        "terms_ts_body_1":"<p>PEtererasdascas <strong>asiodfuh</strong> aoispjf a</p>\n",

Converts to

"ts_body":"PEtererasdascas asiodfuh aoispjf a",
        "terms_ts_body":"PEtererasdascas asiodfuh aoispjf a",
        "its_uid":1,
        "itm_field_user_likes":[39,
          41],
        "its_field_user_likes":39,
        "ts_body_1":"PEtererasdascas asiodfuh aoispjf a",
        "terms_ts_body_1":"PEtererasdascas asiodfuh aoispjf a",

Thanks!

I have some nits to pick, comments only. Not setting to needs work, because it's only comments.

1. +++ b/src/Processor/FieldsProcessorPluginBase.php
   @@ -90,11 +96,48 @@ public function setDataTypeHelper(DataTypeHelperInterface $data_type_helper) {
   +    // If the "all supported fields" option is checked, we simply reset the
   +    // "fields" option to contain all supported fields. No need to explicitly
   +    // check for renames, or anything else.
   

   I had to go to the preIndexSave method to have enough context for this comment, but I think we can improve this.

   If the "all supported fields"
    option is checked, we need to reset the fields array and fill it with all fields defined on the index.

2. +++ b/src/Processor/FieldsProcessorPluginBase.php
   @@ -125,40 +168,107 @@ public function preIndexSave() {
   +    // @todo Add "fields" default here, too, and figure out how to replace
   +    //   current "magic" code dealing with unset option (or whether we even need
   +    //   to).
   

   Should we already open an issue for this (and link to it) or do we fix this in this issue?

3. +++ b/src/Processor/FieldsProcessorPluginBase.php
   @@ -125,40 +168,107 @@ public function preIndexSave() {
   +    // Unfortunately, Form API doesn't seem to automatically add the default
   +    // "#pre_render" callbacks to an element if we set some of our own. We
   +    // therefore need to explicitly include those, too.
   

   We need to add pre-render callbacks to checkbox elements because form api doesn't add the default callbacks.

4. +++ b/tests/src/Unit/Plugin/Processor/FieldsProcessorPluginBaseTest.php
   @@ -98,6 +99,47 @@ public function testFieldRenaming() {
   +   * Tests whether the "Enable on all supported fields" option works correctly.
   

   I think we should describe the test a little here.

   Tests whether the "Enable on all supported fields" option works correctly.
   
   We want the all_fields option to make sure that all string and text fields are automatically added to the processor.
   

5. +++ b/tests/src/Unit/Plugin/Processor/FieldsProcessorPluginBaseTest.php
   @@ -98,6 +99,47 @@ public function testFieldRenaming() {
   +    // Need to create a new index mock, since overwriting getFields() doesn't
   +    // work correctly otherwise.
   

   Create a new mock for the Index, so we can override getFields method.

   sounds better?

The changes you suggested in the comments sound good, but it looks like you forgot the patch. Waiting for that before setting to rtbc.

Looks great.