Moving top-level term to be a child of another term does not work

I can confirm this with Drupal 8.3.0 ~ Taxonomy Menu 8.3.3

Cache rebuild + cron have no effect

Drupal: 8.3.2
Taxonomy Menu: 8.x-3.3

Millenc: Your fix works, but appears to be temporary. I added a new article and the taxonomy went back to the previous broken state.
I changed the settings after it broke and it repaired the issue again.

I wasn't able to reproduce this issue. I didn't face any such problem , when i created taxonomy term , added it as parent for other previously built terms , cleared the cache , menu changed accordingly.

Same bug.

Solve problem.

https://www.drupal.org/node/2762037

But after cache clear, not working:(

Applay patch from here

https://www.drupal.org/node/2830188

and drag and drop in menu, not in taxonomy, and it worked.

but if order taxonomy menu, is change menu weight and order (with this patch https://www.drupal.org/node/2762037), but after cache clear back again.

I think that problem in multilanguage sites.

Same issue here... any news?

I just tested and the changes made to the current 8.x-3.x codebase don't resolve this problem either.

I can also confirm #11.
When creating a term on root level first and then moving it into a deeper level > max depth, the menu item is not being deleted.

I think I have same problem.

I have the same problem with drupal 8.6.3 and last stable release of this menu ( 8.x-3.3 ).

When I add a term, delete a term : no cache problem
When I move a term to another parent : cache problem, I need to rebuild router.

I did a workaround in a custom module, it's an easy hook waiting the fix in the module :

/**
 * Implements hook_entity_type_update().
 */

function  mymodule_custom_taxonomy_term_update( Drupal\Core\Entity\EntityInterface $entity )
{
  //here hierarchy is the vocabulary name used with taxonomy menu
    if( "hierarchy" == $entity->bundle() ){
        \Drupal::service('router.builder')->rebuild();
}

I think that implementing a menu deriver is redundant.

The suggestion in #14 didn't seem to work for my scenario. I took a more extreme approach that deletes the menu item when updating the term. Then the taxonomy menu module will rebuild that menu link if necessary.

/**
 * Implements hook_entity_type_update().
 */
function mymodule_taxonomy_term_update(TermInterface $entity) {
  $original_parent = $entity->original->get('parent')->getString();
  if ($original_parent == $entity->get('parent')->getString()) {
    return;
  }
  $database = \Drupal::database();
  $menu_link_exists = $database->select('menu_tree', 'm')->fields('m')
    ->condition('id', 'taxonomy_menu.menu_link%', 'LIKE')
    ->condition('route_param_key', 'taxonomy_term=' . $entity->id())
    ->countQuery()
    ->execute()
    ->fetchField();

  if ($menu_link_exists > 0) {
    $database->delete('menu_tree')
      ->condition('id', 'taxonomy_menu.menu_link%', 'LIKE')
      ->condition('route_param_key', 'taxonomy_term=' . $entity->id())
      ->execute();
    \Drupal::service('router.builder')->rebuild();
  }
}

This is a more heavy hammer approach but it seems to resolve the issue

Let's add test coverage for this too, to make sure the functionality works as expected.