Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
One more thing needs to be changed due to #2758897: Move rest module's "link manager" services to serialization module
rest.link_manager needs to be changed to hal.link_manager
Comment | File | Size | Author |
---|---|---|---|
#6 | webform_link_manager-2867556-6.patch | 1.31 KB | andypost |
Comments
Comment #2
Shawn DeArmond CreditAttribution: Shawn DeArmond as a volunteer commentedPatch attached.
Comment #3
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented@Shawn DeArmond Does the patch work for 8.2 and 8.3?
I just queued the automated tests for 8.2 but I am not sure the Webform module's REST API integration has enough test coverage to catch 8.2 to 8.3 discrepancies.
Comment #4
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedThe hal.link_manager is not available for 8.2.
Here is the change record REST module's "link manager" services (and 'link_domain' setting) moved to hal module.
Comment #5
andypostTo keep BC kinda that
Comment #6
andypostWith comment and clean-up
Comment #7
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented@andypost Your patch just made me LOL, imagine 100's of modules having to do this.
Comment #9
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #10
andypost@jrockowitz yep, lots of stupid patches otoh some modules can remove rest from dependencies
also it makes sense to add to if
isset($modules['rest'])
andisset($modules['hal'])
somehowComment #11
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented@andypost I am open to any additional patches.
Comment #12
alexpottFiled an update to make this a bit more robust. #2869420: Yet another ServiceNotFoundException: The service "serializer.normalizer.webform_entity_reference_item" has a dependency on a non-existent service "rest.link_manager".