Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shawn DeArmond created an issue. See original summary.

Shawn DeArmond’s picture

Patch attached.

jrockowitz’s picture

@Shawn DeArmond Does the patch work for 8.2 and 8.3?

I just queued the automated tests for 8.2 but I am not sure the Webform module's REST API integration has enough test coverage to catch 8.2 to 8.3 discrepancies.

jrockowitz’s picture

Status: Needs review » Needs work

The hal.link_manager is not available for 8.2.

Here is the change record REST module's "link manager" services (and 'link_domain' setting) moved to hal module.

andypost’s picture

To keep BC kinda that

andypost’s picture

jrockowitz’s picture

@andypost Your patch just made me LOL, imagine 100's of modules having to do this.

jrockowitz’s picture

Status: Needs review » Fixed
andypost’s picture

@jrockowitz yep, lots of stupid patches otoh some modules can remove rest from dependencies

+++ b/src/WebformServiceProvider.php
@@ -19,8 +20,10 @@ class WebformServiceProvider extends ServiceProviderBase {
     if (isset($modules['hal'])) {
...
+      $manager = $container->has('hal.link_manager') ? 'hal.link_manager' : 'rest.link_manager';

also it makes sense to add to if
isset($modules['rest']) and isset($modules['hal']) somehow

jrockowitz’s picture

@andypost I am open to any additional patches.

alexpott’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.