Timestamp Ago Formatter: Future and past format not selectable due to incorrect variable name...

Pushing patch for future and past format for time ago formatter also rewriting summary, replacing deprecated functions in formating timestamp. this also should solve https://www.drupal.org/node/2427195

Thanks. We really need to scope this to just fix the bug, and not other things, too. So, let's just fix the settings form here.

+++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/TimestampAgoFormatter.php
@@ -174,7 +177,7 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
-   * @return array
+   * @return FormattableMarkup
    *   The formatted timestamp string using the past or future format setting.
    */
   protected function formatTimestamp($timestamp) {
@@ -186,18 +189,14 @@ protected function formatTimestamp($timestamp) {

@@ -186,18 +189,14 @@ protected function formatTimestamp($timestamp) {
 
     if ($this->request->server->get('REQUEST_TIME') > $timestamp) {
       $result = $this->dateFormatter->formatTimeDiffSince($timestamp, $options);
-      $build = [
-        '#markup' => SafeMarkup::format($this->getSetting('past_format'), ['@interval' => $result->getString()]),
-      ];
+      $setting = $this->getSetting('past_format');
     }
     else {
       $result = $this->dateFormatter->formatTimeDiffUntil($timestamp, $options);
-      $build = [
-        '#markup' => SafeMarkup::format($this->getSetting('future_format'), ['@interval' => $result->getString()]),
-      ];
+      $setting = $this->getSetting('future_format');
     }
-    CacheableMetadata::createFromObject($result)->applyTo($build);
-    return $build;
+
+    return new FormattableMarkup($setting, ['@interval' => $result->getString()]);
   }

This is out of scope, but this is not a correct change. This needs to return a render array fragment to propagate the cache data from the date formatter.

@mpdonadio

Pushing patch just for settings form.
Summary will then be fixed in https://www.drupal.org/node/2686409

+++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/TimestampAgoFormatter.php
@@ -106,14 +106,14 @@ public static function defaultSettings() {
-    $form['future_format'] = [
+    $elements['future_format'] = [

The fact that this big of a change doesn't trigger any sort of test failure indicates a pretty big lack of test coverage for this formatter, so marking as 'needs tests'.

Moved the work in #2686409: Time Ago summary does not render on Manage Display for Timestamp and Datetime fields. Closing this as duplicate of #2686409: Time Ago summary does not render on Manage Display for Timestamp and Datetime fields.