Closed (duplicate)
Project:
Drupal core
Version:
8.4.x-dev
Component:
datetime.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Apr 2017 at 01:39 UTC
Updated:
21 Nov 2017 at 17:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
himanshu-dixit commentedComment #5
xsdx commentedPushing patch for future and past format for time ago formatter also rewriting summary, replacing deprecated functions in formating timestamp. this also should solve https://www.drupal.org/node/2427195
Comment #6
xsdx commentedComment #7
mpdonadioThanks. We really need to scope this to just fix the bug, and not other things, too. So, let's just fix the settings form here.
This is out of scope, but this is not a correct change. This needs to return a render array fragment to propagate the cache data from the date formatter.
Comment #8
xsdx commented@mpdonadio
Pushing patch just for settings form.
Summary will then be fixed in https://www.drupal.org/node/2686409
Comment #9
xsdx commentedComment #11
jhedstromThe fact that this big of a change doesn't trigger any sort of test failure indicates a pretty big lack of test coverage for this formatter, so marking as 'needs tests'.
Comment #12
claudiu.cristeaMoved the work in #2686409: Time Ago summary does not render on Manage Display for Timestamp and Datetime fields. Closing this as duplicate of #2686409: Time Ago summary does not render on Manage Display for Timestamp and Datetime fields.
Comment #13
mpdonadio